net/net.gyp - Issue 6670085: FTP: Detect the character encoding only after the entire listing is received. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(432)

My Issues | Starred Open | Closed | All

Unified Diff: net/net.gyp

Issue 6670085: FTP: Detect the character encoding only after the entire listing is received. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test coverage Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « net/ftp/ftp_directory_listing_parser_windows_unittest.cc ('k') | webkit/glue/ftp_directory_listing_response_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/net.gyp

diff --git a/net/net.gyp b/net/net.gyp

index 4bb30b5a2d746eaf06ad2edb788746e4d338f191..e3837deedeba4836356cac31793a61997e2f5f61 100644

--- a/net/net.gyp

+++ b/net/net.gyp

@@ -426,8 +426,6 @@

'ftp/ftp_auth_cache.h',

'ftp/ftp_ctrl_response_buffer.cc',

'ftp/ftp_ctrl_response_buffer.h',

- 'ftp/ftp_directory_listing_buffer.cc',

- 'ftp/ftp_directory_listing_buffer.h',

'ftp/ftp_directory_listing_parser.cc',

'ftp/ftp_directory_listing_parser.h',

'ftp/ftp_directory_listing_parser_ls.cc',

@@ -931,9 +929,9 @@

'disk_cache/storage_block_unittest.cc',

'ftp/ftp_auth_cache_unittest.cc',

'ftp/ftp_ctrl_response_buffer_unittest.cc',

- 'ftp/ftp_directory_listing_buffer_unittest.cc',

'ftp/ftp_directory_listing_parser_ls_unittest.cc',

'ftp/ftp_directory_listing_parser_netware_unittest.cc',

+ 'ftp/ftp_directory_listing_parser_unittest.cc',

'ftp/ftp_directory_listing_parser_vms_unittest.cc',

'ftp/ftp_directory_listing_parser_windows_unittest.cc',

'ftp/ftp_network_transaction_unittest.cc',

« no previous file with comments | « net/ftp/ftp_directory_listing_parser_windows_unittest.cc ('k') | webkit/glue/ftp_directory_listing_response_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698