Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 6670083: Partially fix serializer which crashes on x64 running with no snapshot.... (Closed)

Created:
9 years, 9 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Partially fix serializer which crashes on x64 running with no snapshot. We used the wrong heap space number when reading in code chunks (we used LO_SPACE, should use kLargeCode). Committed: http://code.google.com/p/v8/source/detail?r=7213

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/serialize.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 9 months ago (2011-03-17 07:55:49 UTC) #1
Erik Corry
9 years, 9 months ago (2011-03-17 08:06:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698