Issue 6670074: GPU process - parent GL context does not delete the textures it shares with c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6670074: GPU process - parent GL context does not delete the textures it shares with c... (Closed)

Created:
9 years, 9 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
greggman

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GPU process - parent GL context does not delete the textures it shares with child contexts. The child contexts create them and are then responsible for deleting them. This fixed a crash where the child contexts were passing an invalid texture ID to glBlitFramebufferANGLE. TEST=can't reproduce bug locally anymore, trybots BUG=75661 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78642

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -5 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/texture_manager.h	View	1	4 chunks	+11 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager_unittest.cc	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Done

Expand Messages | Collapse Messages