Issue 6670031: Fix compile failure with GCC 4.5.0 (issue 1244)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6670031: Fix compile failure with GCC 4.5.0 (issue 1244)... (Closed)

Created:
9 years, 9 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix compile failure with GCC 4.5.0 (issue 1244) GCC apparently assumes that given that we do a static cast in the next line the value must actually be in StrictModeFlag enum range (even though this is actually what we are asserting) Committed: http://code.google.com/p/v8/source/detail?r=7147

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/v8globals.h	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/6670031/diff/1/src/v8globals.h File src/v8globals.h (right): http://codereview.chromium.org/6670031/diff/1/src/v8globals.h#newcode476 src/v8globals.h:476: kInvalidStrictFlag How about a comment.

9 years, 9 months ago (2011-03-11 10:55:53 UTC) #2

Rico

9 years, 9 months ago (2011-03-11 11:02:22 UTC) #3

http://codereview.chromium.org/6670031/diff/1/src/v8globals.h
File src/v8globals.h (right):

http://codereview.chromium.org/6670031/diff/1/src/v8globals.h#newcode476
src/v8globals.h:476: kInvalidStrictFlag
On 2011/03/11 10:55:53, William Hesse wrote:
> How about a comment.

Done.

Expand Messages | Collapse Messages