Issue 6667077: Revert revisions 7215 and 7212.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6667077: Revert revisions 7215 and 7212. (Closed)

Created:
9 years, 9 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert revisions 7215 and 7212. This caueses line positions to be off by one in certain cases, causing webkit http/tests/inspector/console-xhr-logging to fail. Committed: http://code.google.com/p/v8/source/detail?r=7239

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+113 lines, -343 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	src/arm/lithium-arm.h	View	2 chunks	+4 lines, -20 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	src/ast.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ast.cc	View	1 chunk	+16 lines, -13 lines	0 comments	Download
M	src/hydrogen.h	View	4 chunks	+3 lines, -12 lines	0 comments	Download
M	src/hydrogen.cc	View	8 chunks	+45 lines, -66 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	4 chunks	+5 lines, -38 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+1 line, -14 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+4 lines, -22 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	2 chunks	+4 lines, -20 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	test/mjsunit/compiler/global-accessors.js	View	1 chunk	+0 lines, -47 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rubberstamp LGTM.

Expand Messages | Collapse Messages