Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 6667071: Build skia as a dll in windows multi-dll build (without adding gpu dependenci... (Closed)

Created:
9 years, 9 months ago by Chris Guillory
Modified:
9 years, 7 months ago
Reviewers:
twiz, reed1
CC:
chromium-reviews, bsalomon, Jeff Timanus
Visibility:
Public.

Description

Build skia as a dll in windows multi-dll build (without adding gpu dependencies). * Not for submit * Verification that skia currently doesn't require gpu dependencies to build chrome. * See: http://codereview.chromium.org/6682011/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -47 lines) Patch
M ppapi/ppapi_shared_proxy.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/image_data_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/google_logging.cc View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/image_operations.h View 1 chunk +3 lines, -1 line 0 comments Download
M skia/ext/platform_canvas.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/platform_device_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M skia/ext/skia_utils_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/vector_canvas.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 5 chunks +54 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
I believe there is an independent CL in the works to remove skia and ganesh's ...
9 years, 9 months ago (2011-03-17 12:18:41 UTC) #1
bsalomon
Yes, Jeff is working on this. I think we're close to resolving it. Jeff has ...
9 years, 9 months ago (2011-03-17 13:14:34 UTC) #2
twiz
9 years, 9 months ago (2011-03-18 21:10:22 UTC) #3
On 2011/03/17 13:14:34, bsalomon wrote:
> Yes, Jeff is working on this. I think we're close to resolving it. Jeff has
> made a lot of progress towards removing dependence on a particular GL
> implementation in the Gr subsystem.  (See
> http://codereview.chromium.org/6677105/)
> 
> On Thu, Mar 17, 2011 at 8:18 AM, <mailto:reed@google.com> wrote:
> 
> > I believe there is an independent CL in the works to remove skia and
> > ganesh's
> > dependency on command-buffer/gl. We are switching to a runtime function-ptr
> > technique to allow skia to find opengl. With that change it seems we can
> > completely remove the need to link against cmd-buffer.
> >
> > Jeff/Brian, can you comment?

Yes, all dependencies on GL headers have been removed from Ganesh.

See CLs: 
  http://codereview.appspot.com/4298048/
  http://codereview.appspot.com/4272061

However, the assignment of default function-pointer binding assume that a gl
implementation exists.  A small bit of work would be required to build skia
without linking to a GL library.  See the only remaining direct-callers of GL in
http://code.google.com/p/skia/source/browse/trunk/gpu/src/GrGLInterface.cpp

Jeff

> >
> > http://codereview.chromium.org/6667071/
> >

Powered by Google App Engine
This is Rietveld 408576698