Issue 6667042: Revert both r78355 and r78329

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6667042: Revert both r78355 and r78329 (Closed)

Created:
9 years, 9 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Revert both r78355 and r78329 "Fix regression introduced in r78329." "Modify gcl to use suggested_reviewer output from presubmit_support." My quick fix was insufficient. TBR=dpranke Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78356

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -90 lines)			Patch
	M	gcl.py	View		12 chunks	+18 lines, -77 lines	0 comments	Download
	M	tests/gcl_unittest.py	View		6 chunks	+7 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages