Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 6667032: Support the 'use_system_yasm' variable (libjpeg_turbo).... (Closed)

Created:
9 years, 9 months ago by Hironori Bono
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Support the 'use_system_yasm' variable (libjpeg_turbo). This change uses yasm installed to the system to build libjpeg_turbo if 'use_system_yasm' is 1 as requested by 'fta@ubuntu.com'. BUG=none TEST=build Chromium Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78340

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -76 lines) Patch
M libjpeg.gyp View 1 3 chunks +60 lines, -76 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hironori Bono
9 years, 9 months ago (2011-03-11 15:56:14 UTC) #1
Mark Mentovai
http://codereview.chromium.org/6667032/diff/1/libjpeg.gyp File libjpeg.gyp (right): http://codereview.chromium.org/6667032/diff/1/libjpeg.gyp#newcode190 libjpeg.gyp:190: [ 'use_system_yasm==1', { Shouldn’t this be ==0?
9 years, 9 months ago (2011-03-11 16:00:22 UTC) #2
Hironori Bono
Greetings Mark, Thank you for your quick review. I have updated the change to apply ...
9 years, 9 months ago (2011-03-11 16:06:10 UTC) #3
Mark Mentovai
9 years, 9 months ago (2011-03-11 16:08:27 UTC) #4
That’s better! LGTM. Hope everyone’s doing OK over there.

Powered by Google App Engine
This is Rietveld 408576698