src/isolate.h - Issue 6665063: [Isolates] Fix the crash in AssertNoContextChange ctor when current context i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.h

Issue 6665063: [Isolates] Fix the crash in AssertNoContextChange ctor when current context i... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/isolates/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.h

===================================================================

--- src/isolate.h (revision 7210)

+++ src/isolate.h (working copy)

@@ -1180,7 +1180,9 @@

#ifdef DEBUG

public:

AssertNoContextChange() :

- context_(Isolate::Current()->context()) {

+ isolate_(Isolate::Current()),

Vitaly Repeshko 2011/03/17 18:13:43 Convert tabs to spaces.

+ scope_(isolate_),

+ context_(isolate_->context(), isolate_) {

Vitaly Repeshko 2011/03/17 18:13:43 Just pass Isolate::Current(). No need to save it i

}

~AssertNoContextChange() {

@@ -1188,6 +1190,7 @@

}

private:

+ Isolate* isolate_;

HandleScope scope_;

Handle<Context> context_;

#else

« no previous file with comments | « no previous file | no next file » | no next file with comments »