Added new config for pnacl2 bot to test spec 2k in train mode for all platfor...

Added new config for pnacl2 bot to test spec 2k in train mode for all platforms.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=1497
TEST= gcl try bots --bot nacl-lucid64-pnacl2
Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=4567

[robertm, 2011-03-16 21:22:01]

PTAL

[bradn, 2011-03-16 21:26:22]

LGTM otherwise

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh
File buildbot/buildbot_pnacl2.sh (right):

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh#new...
buildbot/buildbot_pnacl2.sh:48: 
Drop trailing line.

[jvoung - send to chromium..., 2011-03-16 21:36:41]

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh
File buildbot/buildbot_pnacl2.sh (right):

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh#new...
buildbot/buildbot_pnacl2.sh:35: for setup in SetupPnaclArmOpt SetupPnaclX8632Opt
SetupPnaclX8664Opt ; do
Should we try the SetupPnaclTranslatorX8632Opt w/ say, one test too, just in
case?

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh#new...
buildbot/buildbot_pnacl2.sh:38: ./run_all.sh PopulateFromSpecHarness
${SPEC_HARNESS}
Clean and Populate may only need to be done once, instead of once for each
Setup. Should be "fast" for local disk, but could be slow if going over NFS.

[robertm, 2011-03-16 22:22:29]

PTAL

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh
File buildbot/buildbot_pnacl2.sh (right):

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh#new...
buildbot/buildbot_pnacl2.sh:35: for setup in SetupPnaclArmOpt SetupPnaclX8632Opt
SetupPnaclX8664Opt ; do
added on with gcc
On 2011/03/16 21:36:41, jvoung wrote:
> Should we try the SetupPnaclTranslatorX8632Opt w/ say, one test too, just in
> case?

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh#new...
buildbot/buildbot_pnacl2.sh:38: ./run_all.sh PopulateFromSpecHarness
${SPEC_HARNESS}
could not get this work - so leaving as is.

On 2011/03/16 21:36:41, jvoung wrote:
> Clean and Populate may only need to be done once, instead of once for each
> Setup. Should be "fast" for local disk, but could be slow if going over NFS.

http://codereview.chromium.org/6665045/diff/1/buildbot/buildbot_pnacl2.sh#new...
buildbot/buildbot_pnacl2.sh:48: 
On 2011/03/16 21:26:22, bradn wrote:
> Drop trailing line.

Done.

[jvoung - send to chromium..., 2011-03-16 22:28:29]

LGTM

http://codereview.chromium.org/6665045/diff/2003/buildbot/buildbot_pnacl2.sh
File buildbot/buildbot_pnacl2.sh (right):

http://codereview.chromium.org/6665045/diff/2003/buildbot/buildbot_pnacl2.sh#...
buildbot/buildbot_pnacl2.sh:18: # Rought test running time classification for
ARM which is our bottleneck
s/Rought/Rough/

[robertm, 2011-03-17 22:09:22]

I made a lot more changes including parallel make (helps a little) 

PTAL


On 2011/03/16 22:28:29, jvoung wrote:
> LGTM
> 
> http://codereview.chromium.org/6665045/diff/2003/buildbot/buildbot_pnacl2.sh
> File buildbot/buildbot_pnacl2.sh (right):
> 
>
http://codereview.chromium.org/6665045/diff/2003/buildbot/buildbot_pnacl2.sh#...
> buildbot/buildbot_pnacl2.sh:18: # Rought test running time classification for
> ARM which is our bottleneck
> s/Rought/Rough/

[bradn, 2011-03-17 22:16:02]

Still LGTM

[jvoung - send to chromium..., 2011-03-17 22:17:32]

http://codereview.chromium.org/6665045/diff/9001/buildbot/buildbot_pnacl2.sh
File buildbot/buildbot_pnacl2.sh (right):

http://codereview.chromium.org/6665045/diff/9001/buildbot/buildbot_pnacl2.sh#...
buildbot/buildbot_pnacl2.sh:83: ./run_all.sh CleanBenchmarks
CleanBenchmarks and PopulateFromSpecHarness can also take a list of the
benchmarks to clean/copy over. Assuming TestsToBuild is always a superset of
TestsToRun, you can use that list to save a bit of time.

http://codereview.chromium.org/6665045/diff/9001/buildbot/buildbot_pnacl2.sh#...
buildbot/buildbot_pnacl2.sh:85: ./run_all.sh BuildBenchmarks 0 ${setup}
$(TestsToBuild ${setup})
did you want to specify some parallelism with MAKEOPTS?

[robertm, 2011-03-17 22:26:03]

still struggling to get this under 30min - pruned art and crafty as well

http://codereview.chromium.org/6665045/diff/9001/buildbot/buildbot_pnacl2.sh
File buildbot/buildbot_pnacl2.sh (right):

http://codereview.chromium.org/6665045/diff/9001/buildbot/buildbot_pnacl2.sh#...
buildbot/buildbot_pnacl2.sh:83: ./run_all.sh CleanBenchmarks
The time savings were not very big - will leave as is

On 2011/03/17 22:17:32, jvoung wrote:
> CleanBenchmarks and PopulateFromSpecHarness can also take a list of the
> benchmarks to clean/copy over. Assuming TestsToBuild is always a superset of
> TestsToRun, you can use that list to save a bit of time.

http://codereview.chromium.org/6665045/diff/9001/buildbot/buildbot_pnacl2.sh#...
buildbot/buildbot_pnacl2.sh:85: ./run_all.sh BuildBenchmarks 0 ${setup}
$(TestsToBuild ${setup})
I was debating where to put the MAKEOPTS=-j8 
ended up putting it into this file

On 2011/03/17 22:17:32, jvoung wrote:
> did you want to specify some parallelism with MAKEOPTS?

[jvoung - send to chromium..., 2011-03-17 22:30:45]

LGTM