Dramatically speed up detailed heap snapshot generation.

src/profile-generator.h

Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index 559ffc627fcee1cc17735f35157c820868554b6d..2c9383b1e78997071ab881479030d92d39754aa7 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -1019,6 +1019,7 @@ class V8HeapExplorer : public HeapEntriesAllocator {
   void ExtractPropertyReferences(JSObject* js_obj, HeapEntry* entry);
   void ExtractElementReferences(JSObject* js_obj, HeapEntry* entry);
   void ExtractInternalReferences(JSObject* js_obj, HeapEntry* entry);
+  inline void MarkAsFailure(Address field);

[Vitaly Repeshko, 2011/03/17 16:52:00]

Usually such functions hide the exact machinery they use to mark stuff. Call it
"MarkAsVisited"?

[mnaganov (inactive), 2011/03/17 17:37:18]

I've moved it to IndexedReferencesExtractor and renamed to MarkVisitedField.

   void SetClosureReference(HeapObject* parent_obj,
                            HeapEntry* parent,
                            String* reference_name,
@@ -1030,11 +1031,13 @@ class V8HeapExplorer : public HeapEntriesAllocator {
   void SetInternalReference(HeapObject* parent_obj,
                             HeapEntry* parent,
                             const char* reference_name,
-                            Object* child);
+                            Object* child,
+                            Address field = NULL);
   void SetInternalReference(HeapObject* parent_obj,
                             HeapEntry* parent,
                             int index,
-                            Object* child);
+                            Object* child,
+                            Address field = NULL);
   void SetHiddenReference(HeapObject* parent_obj,
                           HeapEntry* parent,
                           int index,
@@ -1042,7 +1045,8 @@ class V8HeapExplorer : public HeapEntriesAllocator {
   void SetPropertyReference(HeapObject* parent_obj,
                             HeapEntry* parent,
                             String* reference_name,
-                            Object* child);
+                            Object* child,
+                            Address field = NULL);
   void SetPropertyShortcutReference(HeapObject* parent_obj,
                                     HeapEntry* parent,
                                     String* reference_name,
@@ -1056,9 +1060,6 @@ class V8HeapExplorer : public HeapEntriesAllocator {
   HeapSnapshot* snapshot_;
   HeapSnapshotsCollection* collection_;
   SnapshottingProgressReportingInterface* progress_;
-  // Used during references extraction to mark heap objects that
-  // are references via non-hidden properties.
-  HeapObjectsSet known_references_;
   SnapshotFillerInterface* filler_;
 
   static HeapObject* const kGcRootsObject;