Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.h

Issue 6665038: Dramatically speed up detailed heap snapshot generation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comments addressed Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | src/profile-generator.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1569 matching lines...) Expand 10 before | Expand all | Expand 10 after
1580 bool HasRealNamedCallbackProperty(String* key); 1580 bool HasRealNamedCallbackProperty(String* key);
1581 1581
1582 // Initializes the array to a certain length 1582 // Initializes the array to a certain length
1583 MUST_USE_RESULT MaybeObject* SetElementsLength(Object* length); 1583 MUST_USE_RESULT MaybeObject* SetElementsLength(Object* length);
1584 1584
1585 // Get the header size for a JSObject. Used to compute the index of 1585 // Get the header size for a JSObject. Used to compute the index of
1586 // internal fields as well as the number of internal fields. 1586 // internal fields as well as the number of internal fields.
1587 inline int GetHeaderSize(); 1587 inline int GetHeaderSize();
1588 1588
1589 inline int GetInternalFieldCount(); 1589 inline int GetInternalFieldCount();
1590 inline int GetInternalFieldOffset(int index);
1590 inline Object* GetInternalField(int index); 1591 inline Object* GetInternalField(int index);
1591 inline void SetInternalField(int index, Object* value); 1592 inline void SetInternalField(int index, Object* value);
1592 1593
1593 // Lookup a property. If found, the result is valid and has 1594 // Lookup a property. If found, the result is valid and has
1594 // detailed information. 1595 // detailed information.
1595 void LocalLookup(String* name, LookupResult* result); 1596 void LocalLookup(String* name, LookupResult* result);
1596 void Lookup(String* name, LookupResult* result); 1597 void Lookup(String* name, LookupResult* result);
1597 1598
1598 // The following lookup functions skip interceptors. 1599 // The following lookup functions skip interceptors.
1599 void LocalLookupRealNamedProperty(String* name, LookupResult* result); 1600 void LocalLookupRealNamedProperty(String* name, LookupResult* result);
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
1697 // Transform slow named properties to fast variants. 1698 // Transform slow named properties to fast variants.
1698 // Returns failure if allocation failed. 1699 // Returns failure if allocation failed.
1699 MUST_USE_RESULT MaybeObject* TransformToFastProperties( 1700 MUST_USE_RESULT MaybeObject* TransformToFastProperties(
1700 int unused_property_fields); 1701 int unused_property_fields);
1701 1702
1702 // Access fast-case object properties at index. 1703 // Access fast-case object properties at index.
1703 inline Object* FastPropertyAt(int index); 1704 inline Object* FastPropertyAt(int index);
1704 inline Object* FastPropertyAtPut(int index, Object* value); 1705 inline Object* FastPropertyAtPut(int index, Object* value);
1705 1706
1706 // Access to in object properties. 1707 // Access to in object properties.
1708 inline int GetInObjectPropertyOffset(int index);
1707 inline Object* InObjectPropertyAt(int index); 1709 inline Object* InObjectPropertyAt(int index);
1708 inline Object* InObjectPropertyAtPut(int index, 1710 inline Object* InObjectPropertyAtPut(int index,
1709 Object* value, 1711 Object* value,
1710 WriteBarrierMode mode 1712 WriteBarrierMode mode
1711 = UPDATE_WRITE_BARRIER); 1713 = UPDATE_WRITE_BARRIER);
1712 1714
1713 // initializes the body after properties slot, properties slot is 1715 // initializes the body after properties slot, properties slot is
1714 // initialized by set_properties 1716 // initialized by set_properties
1715 // Note: this call does not update write barrier, it is caller's 1717 // Note: this call does not update write barrier, it is caller's
1716 // reponsibility to ensure that *v* can be collected without WB here. 1718 // reponsibility to ensure that *v* can be collected without WB here.
(...skipping 4867 matching lines...) Expand 10 before | Expand all | Expand 10 after
6584 } else { 6586 } else {
6585 value &= ~(1 << bit_position); 6587 value &= ~(1 << bit_position);
6586 } 6588 }
6587 return value; 6589 return value;
6588 } 6590 }
6589 }; 6591 };
6590 6592
6591 } } // namespace v8::internal 6593 } } // namespace v8::internal
6592 6594
6593 #endif // V8_OBJECTS_H_ 6595 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | src/profile-generator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698