Don't show startup infobars in non-startup Browsers.

Don't show startup infobars in non-startup Browsers.

r75602 introduced a regression by adding startup infobars when restoring
a session: startup infobars would be shown in each new Browser (i.e.
when a user creates a new window in an existing session via
ProcessSingleton).

BUG=75654
TEST=Start Chrome, navigate somewhere and crash it. Start Chrome again.  Note the startup infobar. Start Chrome again so that a window is created in the existing session. There should not be any startup infobars.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77820

[Ben Goodger (Google), 2011-03-10 22:46:48]

OK

On Thu, Mar 10, 2011 at 12:57 PM, <agl@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Don't show startup infobars in non-startup Browsers.
>
> r75602 introduced a regression by adding startup infobars when restoring
> a session: startup infobars would be shown in each new Browser (i.e.
> when a user creates a new window in an existing session via
> ProcessSingleton).
>
> BUG=75654
> TEST=Start Chrome, navigate somewhere and crash it. Start Chrome again.
>  Note
> the startup infobar. Start Chrome again so that a window is created in the
> existing session. There should not be any startup infobars.
>
> Please review this at http://codereview.chromium.org/6665003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/process_singleton_linux.cc
>  M chrome/browser/ui/browser_init.cc
>
>
> Index: chrome/browser/process_singleton_linux.cc
> diff --git a/chrome/browser/process_singleton_linux.cc
> b/chrome/browser/process_singleton_linux.cc
> index
>
4ec9f9e6bee901add7dafc6331c203497a79394a..490a09afb6f0eebd187c851a85530adb982573da
> 100644
> --- a/chrome/browser/process_singleton_linux.cc
> +++ b/chrome/browser/process_singleton_linux.cc
> @@ -648,7 +648,8 @@ void ProcessSingleton::LinuxWatcher::HandleMessage(
>     // signalling process.
>     FilePath current_dir_file_path(current_dir);
>     BrowserInit::ProcessCommandLine(parsed_command_line,
> current_dir_file_path,
> -                                    false, profile, NULL);
> +                                    false /* not process startup */,
> profile,
> +                                    NULL);
>   }
>
>   // Send back "ACK" message to prevent the client process from starting
> up.
> Index: chrome/browser/ui/browser_init.cc
> diff --git a/chrome/browser/ui/browser_init.cc
> b/chrome/browser/ui/browser_init.cc
> index
>
29c74833658105e7f64d92c9981f77191be9769a..3d775c8f72a23a17e6e750d145b909b13fce0116
> 100644
> --- a/chrome/browser/ui/browser_init.cc
> +++ b/chrome/browser/ui/browser_init.cc
> @@ -890,7 +890,8 @@ void BrowserInit::LaunchWithProfile::ProcessLaunchURLs(
>     browser = BrowserList::GetLastActiveWithProfile(profile_);
>
>   browser = OpenURLsInBrowser(browser, process_startup, adjust_urls);
> -  AddInfoBarsIfNecessary(browser);
> +  if (process_startup)
> +    AddInfoBarsIfNecessary(browser);
>  }
>
>  bool BrowserInit::LaunchWithProfile::ProcessStartupURLs(
>
>
>