Add base::SHA1HashBytes

base/sha1_portable.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sha1.h"
 
 #include "base/basictypes.h"
+#include <cstring>

[wtc, 2011/03/11 18:46:15]

1. Nit: I recommend including the C header <string.h>
instead of <cstring> for consistency with existing usage
in the Chromium code base.  See line 25, for example.  (I
know it's inside a comment.)

2. The headers should be listed in this order:

#include "base/sha1.h"

#include <string.h> // or <cstring>

#include "base/basictypes.h"

See the Style Guide:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...

[hans, 2011/03/13 19:48:16]

done
done

 
 namespace base {
 
 // Implementation of SHA-1. Only handles data in byte-sized blocks,
 // which simplifies the code a fair bit.
 
 // Identifier names follow notation in FIPS PUB 180-3, where you'll
 // also find a description of the algorithm:
 // http://csrc.nist.gov/publications/fips/fips180-3/fips180-3_final.pdf
 
@@ skipping 169 matching lines @@
   // e.
   H[0] += A;
   H[1] += B;
   H[2] += C;
   H[3] += D;
   H[4] += E;
 
   cursor = 0;
 }
 
 std::string SHA1HashString(const std::string& str) {

[wtc, 2011/03/11 18:46:15]

Nit: ideally this function should be reimplemented using
SHA1HashBytes.

[hans, 2011/03/13 19:48:16]

Done.

   SecureHashAlgorithm sha;
   sha.Update(str.c_str(), str.length());
   sha.Final();
   std::string out(reinterpret_cast<const char*>(sha.Digest()),
                   SecureHashAlgorithm::kDigestSizeBytes);
   return out;
 }
 
+void SHA1HashBytes(const unsigned char* data, size_t len,
+                   unsigned char* hash_array) {
+  SecureHashAlgorithm sha;
+  sha.Update(data, len);
+  sha.Final();
+
+  std::memcpy(hash_array, sha.Digest(), SecureHashAlgorithm::kDigestSizeBytes);
+}
+
 }  // namespace base