Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2856)

Unified Diff: chrome/browser/resources/touch_ntp/tools/check

Issue 6661024: Use a specialized new tab page in TOUCH_UI builds (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Tweaks based on CR feedback from arv Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/touch_ntp/tools/check
diff --git a/chrome/browser/resources/touch_ntp/tools/check b/chrome/browser/resources/touch_ntp/tools/check
new file mode 100755
index 0000000000000000000000000000000000000000..fb44fc6e5bf69912e0368811821ae174ba7c1832
--- /dev/null
+++ b/chrome/browser/resources/touch_ntp/tools/check
@@ -0,0 +1,37 @@
+#!/bin/bash
+
+# Copyright (c) 2008 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# This script checks the touch_ntp code for common errors and style
+# problems using the closure compiler (jscompiler) and closure linter
+# (gjslint) - both of which must be on the path.
+# See http://code.google.com/closure/compiler/ and
+# http://code.google.com/closure/utilities/ for details on these tools.
+
+# Note that we throw away the output from jscompiler since it's use
+# is not yet common in Chromium and for now we want it to be an optional
+# tool for helping to find bugs, not something that actually changes
+# the embedded JavaScript (making it harder to debug, for example).
+
+SOURCES="eventtracker.js touchhandler.js slider.js newtab.js grabber.js "
+SOURCES+="standalone/standalone_hack.js"
+
+ARGS="--warning_level VERBOSE"
+
+# Don't waste time doing optimizations
+ARGS+=" --compilation_level WHITESPACE_ONLY"
+
+ARGS+=" --js_output_file /dev/null"
+for S in $SOURCES tools/externs.js; do
+ ARGS+=" --js $S"
+done
+
+cd `dirname $0`/..
+
+echo jscompiler $ARGS
+jscompiler $ARGS || exit 1
+
+echo gjslint $SOURCES
+gjslint $SOURCES || exit 1

Powered by Google App Engine
This is Rietveld 408576698