chrome/browser/resources/touch_ntp/newtab.html - Issue 6661024: Use a specialized new tab page in TOUCH_UI builds

Side by Side Diff: chrome/browser/resources/touch_ntp/newtab.html

Issue 6661024: Use a specialized new tab page in TOUCH_UI builds (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/touch_ntp/newtab.css ('K') | « chrome/browser/resources/touch_ntp/newtab.css ('k') | chrome/browser/resources/touch_ntp/newtab.js » ('j') | chrome/browser/resources/touch_ntp/standalone/standalone_hack.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <meta charset="utf-8">

	5 <title i18n-content="title"></title>

	6 <link rel="stylesheet" href="newtab.css">

	7 <!-- Don't scale the viewport in either portrait or landscape mode.

	8 Note that this means apps will be reflowed when rotated (like iPad).

	9 If we wanted to maintain position we could remove 'maximum-scale' so

	10 that we'd zoom out in portrait mode, but then there would be a bunch

	11 of unusable space at the bottom.

	12 -->

	13 <meta name="viewport" content="user-scalable=no, width=device-width, maximum-s cale=1.0" />
	arv (Not doing code reviews) 2011/03/10 19:25:59 No /> in HTML No /> in HTML Rick Byers 2011/03/11 02:44:33 Done. Show quoted text On 2011/03/10 19:25:59, arv wrote: > No /> in HTML Done.
	14 </head>

	15 <body>

	16 <div id="apps-frame">

	17 <div id="apps-page-list">

	18 <div class="apps-page">

	19 <!-- This is used as a template which JS copies and fills in. The

	20 template itself is never actually displayed. For this HTML to

	21 validate, I need to supply and img src attribute, but to avoid
	arv (Not doing code reviews) 2011/03/10 19:25:59 validation is over rated. Don't let it get to you validation is over rated. Don't let it get to you Rick Byers 2011/03/11 02:44:33 Thanks! I think this comment is stale anyway - Show quoted text On 2011/03/10 19:25:59, arv wrote: > validation is over rated. Don't let it get to you Thanks! I think this comment is stale anyway - I now remove the template from the DOM entirely when the page is loaded, so the qascore extension I was using to validate my HTML shouldn't see it.
	22 errors/warnings in chrome it needs to be a valid image. I use

	23 trash-open because I want to get it preloaded anyway to avoid flicker.

	24 Note that this isn't inside of apps-frame so that we can easily search

	25 for and manipulate all real apps.

	26 An app-container is always a direct child of an apps-page, and is

	27 expected to have a single 'app' child element holding the visible

	28 content, and 'img' and 'span' tags as descendants somewhere.

	29 -->

	30 <div class="app-container" id="app-template">

	31 <div class="app">

	32 <img src="trash-open.png"/>

	33 <span>App name</span>

	34 </div>

	35 </div>

	36 </div>

	37 </div>

	38 </div>

	39 <div id="footer">

	40 <ul id="dot-list">

	41 <li class="dot"></li>

	42 </ul>

	43 <div id="trash">

	44 </div>

	45 </div>

	46 <!-- If this page isn't loaded as a chrome extension, try to load the

	47 standalone hacks -->

	48 <script type="text/javascript">
	arv (Not doing code reviews) 2011/03/10 19:25:59 skip type skip type Rick Byers 2011/03/11 02:44:33 Done. But I'm curious why - isn't it better to be Show quoted text On 2011/03/10 19:25:59, arv wrote: > skip type Done. But I'm curious why - isn't it better to be explicit? arv (Not doing code reviews) 2011/03/11 20:08:46 type is optional and defaults to text/javascript i Show quoted text On 2011/03/11 02:44:33, rbyers wrote: > On 2011/03/10 19:25:59, arv wrote: > > skip type > > Done. But I'm curious why - isn't it better to be explicit? type is optional and defaults to text/javascript in HTML5. Less cruft lets us focus on the important things. ...also, no other script type is supported.
	49 if(!window.chrome \|\| !window.chrome.send) {
	arv (Not doing code reviews) 2011/03/10 19:25:59 ws after if ws after if Rick Byers 2011/03/11 02:44:33 Done. Show quoted text On 2011/03/10 19:25:59, arv wrote: > ws after if Done.
	50 // Dynamically reference the standalone script in the source tree. This

	51 // is intentionally obfuscated so that grit doesn't try to embed this
	arv (Not doing code reviews) 2011/03/10 19:25:59 This should be easy to fix in a cleaner way. Take This should be easy to fix in a cleaner way. Take a look at html_inline.py http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/tools/grit/grit/form... Rick Byers 2011/03/11 02:44:33 Perfect, thanks! I was never really happy with th Show quoted text On 2011/03/10 19:25:59, arv wrote: > This should be easy to fix in a cleaner way. Take a look at html_inline.py > > http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/tools/grit/grit/form... Perfect, thanks! I was never really happy with this hack - much better now.
	52 // file in the chrome resources

	53 document.write('<script type=\"text/javascript\" ' +

	54 'src=\"standalone/standalone_hack.js\"></scr' + 'ipt>');

	55 }

	56 </script>

	57 <!-- Substitute localized strings for all elements with il8n-content

	58 attributes. -->

	59 <script type="text/javascript" src="../shared/js/i18n_template.js"></script>

	60 <!-- template data placeholder -->

	61 <script type="text/javascript">

	62 i18nTemplate.process(document, templateData);

	63 </script>

	64

	65 <script type="text/javascript" src="eventtracker.js"></script>

	66 <script type="text/javascript" src="touchhandler.js"></script>

	67 <script type="text/javascript" src="slider.js"></script>

	68 <script type="text/javascript" src="grabber.js"></script>

	69 <script type="text/javascript" src="newtab.js"></script>

	70 </body>

	71 </html>

OLD	NEW