Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 6661010: The code to validate whether plugin dlls are 32 bit failed for some dll's as ... (Closed)

Created:
9 years, 9 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

The code to validate whether plugin dlls are 32 bit failed for some dll's as the attempt to create a memory mapped section with the size of the file fails with the section too large error. As per msdn documentation we can safely pass in 0 for the file size for CreateFileMapping and MapViewOfFile which indicates that the whole file is being mapped. This caused some plugin dlls like acrobat reader 9 to not load in chrome. Fixes bug http://code.google.com/p/chromium/issues/detail?id=75351 BUG=75351 TEST=manually as described in the bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M base/file_util_win.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 9 months ago (2011-03-10 00:55:06 UTC) #1
jam
9 years, 9 months ago (2011-03-10 00:59:08 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698