Issue 6659019: Separate GetMacSecurityServicesLock from cssm_init.h so that we can use...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6659019: Separate GetMacSecurityServicesLock from cssm_init.h so that we can use... (Closed)

Created:
9 years, 9 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, TVL

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Separate GetMacSecurityServicesLock from cssm_init.h so that we can use the function without including CSSM headers. R=thomasvl BUG=none TEST=no compilation errors Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77726

Patch Set 1 #

Total comments: 1

Patch Set 2 : Upload before checkin #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -282 lines)			Patch
M	base/base.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	base/crypto/cssm_init.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	base/crypto/cssm_init.cc	View	3 chunks	+0 lines, -27 lines	0 comments	Download
A +	base/crypto/mac_security_services_lock.h	View	1 chunk	+5 lines, -52 lines	0 comments	Download
A +	base/crypto/mac_security_services_lock.cc	View	2 chunks	+4 lines, -193 lines	0 comments	Download
M	net/base/cert_database_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/keygen_handler_mac.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm http://codereview.chromium.org/6659019/diff/1/base/base.gypi File base/base.gypi (right): http://codereview.chromium.org/6659019/diff/1/base/base.gypi#newcode510 base/base.gypi:510: 'crypto/mac_security_services_lock.h', fyi - if this was security_services_lock_mac.cc the ...

9 years, 9 months ago (2011-03-10 02:06:07 UTC) #2

commit-bot: I haz the power

9 years, 9 months ago (2011-03-10 23:30:11 UTC) #3

Can't process patch for file base/crypto/mac_security_services_lock.h.
A  +

Expand Messages | Collapse Messages