Change __defineGetter__ and __defineSetter__ to respect non-configurable....

src/v8natives.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 233 matching lines @@
 
 
 // Extensions for providing property getters and setters.
 function ObjectDefineGetter(name, fun) {
   if (this == null && !IS_UNDETECTABLE(this)) {
     throw new $TypeError('Object.prototype.__defineGetter__: this is Null');
   }
   if (!IS_FUNCTION(fun)) {
     throw new $TypeError('Object.prototype.__defineGetter__: Expecting function');
   }
-  return %DefineAccessor(ToObject(this), ToString(name), GETTER, fun);
+  var desc = { get: fun, enumerable: true, configurable: true };
+  desc = ToPropertyDescriptor(desc);

[Lasse Reichstein, 2011/03/11 07:52:35]

Why not
 var desc = new PropertyDescriptor();
 desc.setEnumerable(true);
 ... etc.

Or at least make it 
  var desc = { ..., __proto__:null };
to ensure against inherited values.

[Rico, 2011/03/11 08:05:48]

Done.

+  DefineOwnProperty(ToObject(this), ToString(name), desc, true);
 }
 
 
 function ObjectLookupGetter(name) {
   if (this == null && !IS_UNDETECTABLE(this)) {
     throw new $TypeError('Object.prototype.__lookupGetter__: this is Null');
   }
   return %LookupAccessor(ToObject(this), ToString(name), GETTER);
 }
 
 
 function ObjectDefineSetter(name, fun) {
   if (this == null && !IS_UNDETECTABLE(this)) {
     throw new $TypeError('Object.prototype.__defineSetter__: this is Null');
   }
   if (!IS_FUNCTION(fun)) {
     throw new $TypeError(
         'Object.prototype.__defineSetter__: Expecting function');
   }
-  return %DefineAccessor(ToObject(this), ToString(name), SETTER, fun);
+  var desc = { set: fun, enumerable: true, configurable: true };

[Lasse Reichstein, 2011/03/11 07:52:35]

Ditto.

[Rico, 2011/03/11 08:05:48]

Done.

+  desc = ToPropertyDescriptor(desc);
+  DefineOwnProperty(ToObject(this), ToString(name), desc, true);
 }
 
 
 function ObjectLookupSetter(name) {
   if (this == null && !IS_UNDETECTABLE(this)) {
     throw new $TypeError('Object.prototype.__lookupSetter__: this is Null');
   }
   return %LookupAccessor(ToObject(this), ToString(name), SETTER);
 }
 
@@ skipping 102 matching lines @@
   this.enumerable_ = false;
   this.hasEnumerable_ = false;
   this.configurable_ = false;
   this.hasConfigurable_ = false;
   this.get_ = void 0;
   this.hasGetter_ = false;
   this.set_ = void 0;
   this.hasSetter_ = false;
 }
 
+//PropertyDescriptor.prototype.__proto__ = null;

[Lasse Reichstein, 2011/03/11 07:52:35]

Uncomment this! :)
And add:
PropertyDescriptor.prototype.toString = function() { return "[object
PropertyDescriptor]"; };

[Rico, 2011/03/11 08:05:48]

Ups, sorry, and done

 
 PropertyDescriptor.prototype.setValue = function(value) {
   this.value_ = value;
   this.hasValue_ = true;
 }
 
 
 PropertyDescriptor.prototype.getValue = function() {
   return this.value_;
 }
@@ skipping 81 matching lines @@
 
 PropertyDescriptor.prototype.hasSetter = function() {
   return this.hasSetter_;
 }
 
 
 // Converts an array returned from Runtime_GetOwnProperty to an actual
 // property descriptor. For a description of the array layout please
 // see the runtime.cc file.
 function ConvertDescriptorArrayToDescriptor(desc_array) {
-  if (desc_array == false) {
+  if (desc_array === false) {
     throw 'Internal error: invalid desc_array';
   }
 
   if (IS_UNDEFINED(desc_array)) {
     return void 0;
   }
 
   var desc = new PropertyDescriptor();
   // This is an accessor.
   if (desc_array[IS_ACCESSOR_INDEX]) {
@@ skipping 38 matching lines @@
   if (props == false) return void 0;
 
   return ConvertDescriptorArrayToDescriptor(props);
 }
 
 
 // ES5 8.12.9.
 function DefineOwnProperty(obj, p, desc, should_throw) {
   var current_or_access = %GetOwnProperty(ToObject(obj), ToString(p));
   // A false value here means that access checks failed.
-  if (current_or_access == false) return void 0;
+  if (current_or_access === false) return void 0;
 
   var current = ConvertDescriptorArrayToDescriptor(current_or_access);
   var extensible = %IsExtensible(ToObject(obj));
 
   // Error handling according to spec.
   // Step 3
   if (IS_UNDEFINED(current) && !extensible)
     throw MakeTypeError("define_disallowed", ["defineProperty"]);
 
   if (!IS_UNDEFINED(current)) {
@@ skipping 675 matching lines @@
 // ----------------------------------------------------------------------------
 
 function SetupFunction() {
   InstallFunctions($Function.prototype, DONT_ENUM, $Array(
     "bind", FunctionBind,
     "toString", FunctionToString
   ));
 }
 
 SetupFunction();