Change __defineGetter__ and __defineSetter__ to respect non-configurable....

Change __defineGetter__ and __defineSetter__ to respect non-configurable.

This makes us compatible with firefox. Earlier on we were somehow
compatible with safari - which will allow defining a getter even when
an existing getter is present and non-configurable. We would, however,
in addition to overwriting the getter also change configurable to
true. The approach used by firefox seems much more sound, i.e., why
should it be possible to use __defineGetter__ or __defineSetter__ to
overwrite a non-configurable getter or setter respectively.

I will file a bug on the webkit bugtracker. 


Committed: http://code.google.com/p/v8/source/detail?r=7143

[Rico, 2011-03-11 07:01:44]

Forgot to svn add the regression test - added now

[Lasse Reichstein, 2011-03-11 07:52:35]

LGTM

http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode255
src/v8natives.js:255: desc = ToPropertyDescriptor(desc);
Why not
 var desc = new PropertyDescriptor();
 desc.setEnumerable(true);
 ... etc.

Or at least make it 
  var desc = { ..., __proto__:null };
to ensure against inherited values.

http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode276
src/v8natives.js:276: var desc = { set: fun, enumerable: true, configurable:
true };
Ditto.

http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode401
src/v8natives.js:401: //PropertyDescriptor.prototype.__proto__ = null;
Uncomment this! :)
And add:
PropertyDescriptor.prototype.toString = function() { return "[object
PropertyDescriptor]"; };

[Rico, 2011-03-11 08:05:48]

http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode255
src/v8natives.js:255: desc = ToPropertyDescriptor(desc);
On 2011/03/11 07:52:35, Lasse Reichstein wrote:
> Why not
>  var desc = new PropertyDescriptor();
>  desc.setEnumerable(true);
>  ... etc.
> 
> Or at least make it 
>   var desc = { ..., __proto__:null };
> to ensure against inherited values.

Done.

http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode276
src/v8natives.js:276: var desc = { set: fun, enumerable: true, configurable:
true };
On 2011/03/11 07:52:35, Lasse Reichstein wrote:
> Ditto.

Done.

http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode401
src/v8natives.js:401: //PropertyDescriptor.prototype.__proto__ = null;
On 2011/03/11 07:52:35, Lasse Reichstein wrote:
> Uncomment this! :)
> And add:
> PropertyDescriptor.prototype.toString = function() { return "[object
> PropertyDescriptor]"; };
Ups, sorry, and done