Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6658005: Add memory size check (Closed)

Created:
9 years, 9 months ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
Hung-Te, Tammo Spalink
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Add memory size check BUG=chrome-os-partner:2129 TEST=works ok Change-Id: I3fdef031e4d774927b65852848493b945e24c7ce Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d488ecb

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 10

Patch Set 5 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M client/site_tests/hardware_Components/hardware_Components.py View 1 2 3 4 5 chunks +21 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
Nick Sanders
Add dram size check to distinguish between 1G, 2G sku
9 years, 9 months ago (2011-03-11 07:52:19 UTC) #1
Tammo Spalink
lgtm, given various ws and format nits http://codereview.chromium.org/6658005/diff/2002/client/site_tests/hardware_Components/hardware_Components.py File client/site_tests/hardware_Components/hardware_Components.py (left): http://codereview.chromium.org/6658005/diff/2002/client/site_tests/hardware_Components/hardware_Components.py#oldcode254 client/site_tests/hardware_Components/hardware_Components.py:254: and keeping ...
9 years, 9 months ago (2011-03-11 07:59:58 UTC) #2
Nick Sanders
http://codereview.chromium.org/6658005/diff/2002/client/site_tests/hardware_Components/hardware_Components.py File client/site_tests/hardware_Components/hardware_Components.py (left): http://codereview.chromium.org/6658005/diff/2002/client/site_tests/hardware_Components/hardware_Components.py#oldcode254 client/site_tests/hardware_Components/hardware_Components.py:254: On 2011/03/11 07:59:58, Tammo Spalink wrote: > and keeping ...
9 years, 9 months ago (2011-03-11 09:40:57 UTC) #3
Hung-Te
9 years, 9 months ago (2011-03-21 03:43:40 UTC) #4 
http://codereview.chromium.org/6658005/diff/6003/client/site_tests/hardware_C...
File client/site_tests/hardware_Components/hardware_Components.py (right):

http://codereview.chromium.org/6658005/diff/6003/client/site_tests/hardware_C...
client/site_tests/hardware_Components/hardware_Components.py:222:
utils.system('modprobe -r i2c_dev')
hold on - this will remove i2c_dev.

"if i2c is not loaded, remove it?"

Powered by Google App Engine
This is Rietveld 408576698