owners.py - Issue 6657028: Actually check Rietveld for LGTMs in CheckOwners()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: owners.py

Issue 6657028: Actually check Rietveld for LGTMs in CheckOwners() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: update w/ review feedback from maruel Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: owners.py

diff --git a/owners.py b/owners.py

index f43deae97b32e0b39896e19d5041044a32673ffa..6a48f43ab81f451228cc84c34faef812d8e2e078 100644

--- a/owners.py

+++ b/owners.py

@@ -44,8 +44,7 @@ class Database(object):

self.fopen = fopen

self.os_path = os_path

- # TODO: Figure out how to share the owners email addr format w/

- # tools/commit-queue/projects.py, especially for per-repo whitelists.

+ # Pick a default email regexp to use; callers can override as desired.

self.email_regexp = re.compile(BASIC_EMAIL_REGEXP)

# Mapping of owners to the paths they own.