presubmit_support.py - Issue 6657028: Actually check Rietveld for LGTMs in CheckOwners()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 6657028: Actually check Rietveld for LGTMs in CheckOwners() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: minor formatting cleanup Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index a62948d9fafbc39fdcfdb832fe6d7b01de73cb9f..0bb62aade0ecc2e9e84c3adc5d04a0a1e2ec2631 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -646,10 +646,6 @@ class Change(object):

self._local_root = os.path.abspath(local_root)

self.issue = issue

self.patchset = patchset

- # TODO(dpranke): implement - get from the patchset?

- self.approvers = set()

self.scm = ''

# From the description text, build up a dictionary of key/value pairs