Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: presubmit_support.py

Issue 6657028: Actually check Rietveld for LGTMs in CheckOwners() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: rename is_tbr to tbr, remove optional email_regexp param from CheckOwners() Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_canned_checks.py ('k') | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index 5e2f8d13e040a2582b056cdf58ed0ed42a6acec2..4c12912dc71e170672749107d95b3e5cd57112b5 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -227,7 +227,10 @@ class InputApi(object):
r"(|.*[\\\/])\.svn[\\\/].*",
)
- def __init__(self, change, presubmit_path, is_committing):
+ # TODO(dpranke): Update callers to pass in tbr, host_url, remove
+ # default arguments.
+ def __init__(self, change, presubmit_path, is_committing, tbr=False,
+ host_url='http://codereview.chromium.org'):
"""Builds an InputApi object.
Args:
@@ -238,7 +241,9 @@ class InputApi(object):
# Version number of the presubmit_support script.
self.version = [int(x) for x in __version__.split('.')]
self.change = change
+ self.host_url = host_url
self.is_committing = is_committing
+ self.tbr = tbr
# We expose various modules and functions as attributes of the input_api
# so that presubmit scripts don't have to import them.
@@ -653,10 +658,6 @@ class Change(object):
self._local_root = os.path.abspath(local_root)
self.issue = issue
self.patchset = patchset
-
- # TODO(dpranke): implement - get from the patchset?
- self.approvers = set()
-
self.scm = ''
# From the description text, build up a dictionary of key/value pairs
« no previous file with comments | « presubmit_canned_checks.py ('k') | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698