Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: PRESUBMIT.py

Issue 6657028: Actually check Rietveld for LGTMs in CheckOwners() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: rename is_tbr to tbr, remove optional email_regexp param from CheckOwners() Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | owners.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 8ea1fd9cf81445a293b9f7ccc3e1aa6573eb9e27..ec7e8a978e065fff14fde3641f13fd2fa338de40 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -20,6 +20,7 @@ UNIT_TESTS = [
'tests.watchlists_unittest',
]
+
def CommonChecks(input_api, output_api):
output = []
# Verify that LocalPath() is local, e.g.:
@@ -31,9 +32,11 @@ def CommonChecks(input_api, output_api):
# Return right away because it needs to be fixed first.
return output
- output.extend(input_api.canned_checks.CheckOwners(
- input_api,
- output_api))
+ # TODO(dpranke): uncomment and enable :).
+ #
+ # output.extend(input_api.canned_checks.CheckOwners(
+ # input_api,
+ # output_api))
output.extend(input_api.canned_checks.RunPythonUnitTests(
input_api,
« no previous file with comments | « no previous file | owners.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698