Issue 6656019: Keyboard localization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6656019: Keyboard localization (Closed)

Created:
9 years, 9 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
Hung-Te, Tammo Spalink

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@0.11.241.B

Visibility:
Public.

Description

Keyboard localization BUG=chrome-os-partner:2591 TEST=runs ok Change-Id: I089846378e819a7bb7638ff3315669e725a64203 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8676bb9

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -0 lines)			Patch
M	client/site_tests/factory_Keyboard/factory_Keyboard.py	View	1 2	2 chunks	+17 lines, -0 lines	0 comments	Download
A	client/site_tests/factory_Keyboard/src/en-US.bindings	View		1 chunk	+79 lines, -0 lines	0 comments	Download
A	client/site_tests/factory_Keyboard/src/en-US.png	View		Binary file		0 comments	Download
A	client/site_tests/factory_SelectKeyboard/factory_SelectKeyboard.py	View	1	1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

9 years, 9 months ago (2011-03-11 07:28:26 UTC) #2

LGTM

http://codereview.chromium.org/6656019/diff/3001/client/site_tests/factory_Ke...
File client/site_tests/factory_Keyboard/factory_Keyboard.py (right):

http://codereview.chromium.org/6656019/diff/3001/client/site_tests/factory_Ke...
client/site_tests/factory_Keyboard/factory_Keyboard.py:133: cmd = 'vpd -l | grep
initial_locale | cut -f4 -d\'"\''
A little concern if some properties in VPD may also have such string... it would
be great if VPD can support printing specified values. Anyway it's OK now.

Expand Messages | Collapse Messages