Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/x509_certificate_mac.cc

Issue 6656015: Map Mac's CSSMERR_APPLETP_INVALID_EMPTY_SUBJECT error to... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Run X509CertificateTest.EmptySubject on all platforms Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/x509_certificate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate_mac.cc
===================================================================
--- net/base/x509_certificate_mac.cc (revision 77730)
+++ net/base/x509_certificate_mac.cc (working copy)
@@ -71,6 +71,14 @@
return CERT_STATUS_REVOKED;
case CSSMERR_APPLETP_HOSTNAME_MISMATCH:
+ // CSSMERR_APPLETP_INVALID_EMPTY_SUBJECT is set if the certificate has an
+ // empty Subject field but the subjectAltName extension is not marked as
+ // critical. This interpretation of RFC 5280 Section 4.1.2.6 is overly
+ // strict. It's not clear whether we can ignore this error, so we report
+ // it, but map it to an overridable error rather than CERT_STATUS_INVALID.
+ // Properly issued certificates should not have this error.
+ // NOTE: to ignore this error, map it to 0.
+ case CSSMERR_APPLETP_INVALID_EMPTY_SUBJECT:
return CERT_STATUS_COMMON_NAME_INVALID;
case CSSMERR_APPLETP_CRL_NOT_FOUND:
« no previous file with comments | « no previous file | net/base/x509_certificate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698