Pepper: Add a property to URLRequestInfo to skip header validation.

webkit/plugins/ppapi/ppb_url_request_info_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_url_request_info_impl.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "googleurl/src/gurl.h"
 #include "net/http/http_util.h"
@@ skipping 174 matching lines @@
   int64_t start_offset;
   int64_t number_of_bytes;
   PP_Time expected_last_modified_time;
 };
 
 PPB_URLRequestInfo_Impl::PPB_URLRequestInfo_Impl(PluginInstance* instance)
     : Resource(instance),
       stream_to_file_(false),
       follow_redirects_(true),
       record_download_progress_(false),
-      record_upload_progress_(false) {
+      record_upload_progress_(false),
+      universal_access_(false) {
 }
 
 PPB_URLRequestInfo_Impl::~PPB_URLRequestInfo_Impl() {
 }
 
 // static
 const PPB_URLRequestInfo* PPB_URLRequestInfo_Impl::GetInterface() {
   return &ppb_urlrequestinfo;
 }
 
 PPB_URLRequestInfo_Impl* PPB_URLRequestInfo_Impl::AsPPB_URLRequestInfo_Impl() {
   return this;
 }
 
 bool PPB_URLRequestInfo_Impl::SetBooleanProperty(PP_URLRequestProperty property,
                                                  bool value) {
   switch (property) {
     case PP_URLREQUESTPROPERTY_STREAMTOFILE:
       stream_to_file_ = value;
       return true;
     case PP_URLREQUESTPROPERTY_FOLLOWREDIRECTS:
       follow_redirects_ = value;
       return true;
     case PP_URLREQUESTPROPERTY_RECORDDOWNLOADPROGRESS:
       record_download_progress_ = value;
       return true;
     case PP_URLREQUESTPROPERTY_RECORDUPLOADPROGRESS:
       record_upload_progress_ = value;
       return true;
+    case PP_URLREQUESTPROPERTY_UNIVERSALACCESS:
+      // Only allow it to be set, not unset.
+      if (universal_access_ && universal_access_ != value)
+        return false;
+      universal_access_ = value;
+      return true;
     default:
       return false;
   }
 }
 
 bool PPB_URLRequestInfo_Impl::SetStringProperty(PP_URLRequestProperty property,
                                                 const std::string& value) {
   // TODO(darin): Validate input.  Perhaps at a different layer?
   switch (property) {
     case PP_URLREQUESTPROPERTY_URL:
       url_ = value;  // NOTE: This may be a relative URL.
       return true;
     case PP_URLREQUESTPROPERTY_METHOD:
       method_ = value;
       return true;
     case PP_URLREQUESTPROPERTY_HEADERS:
-      if (!AreValidHeaders(value))
+      if (!universal_access_ && !AreValidHeaders(value))

[piman, 2011/03/09 02:10:10]

I'm not sure we'd want to allow any arbitrary headers. E.g. connection or
content-length could mess up a lot of things with the protocol

         return false;
       headers_ = value;
       return true;
     default:
       return false;
   }
 }
 
 bool PPB_URLRequestInfo_Impl::AppendDataToBody(const std::string& data) {
   if (!data.empty())
@@ skipping 52 matching lines @@
             body_[i].number_of_bytes,
             body_[i].expected_last_modified_time);
       } else {
         DCHECK(!body_[i].data.empty());
         http_body.appendData(WebData(body_[i].data));
       }
     }
     web_request.setHTTPBody(http_body);
   }
 
   frame->setReferrerForRequest(web_request, WebURL());  // Use default.

[piman, 2011/03/09 02:10:10]

You may want to avoid doing that if the referer is set from the headers ?
Or maybe make the referer an explicit property ?

[viettrungluu, 2011/03/09 02:16:35]

I like this and think we should be as conservative as possible. I don't like the
three-state (use default referer/no referer header/specified referer header)
problem though.

   return web_request;
 }
 
 }  // namespace ppapi
 }  // namespace webkit