CHROMIUM: qcserial: Add support for Gobi 3000 devices.

CHROMIUM: qcserial: Add support for Gobi 3000 devices.

BUG=chromium-os:12380
TEST=Adhoc
With a gobi 3000: boot up, ls /dev/ttyUSB*. You ought to see two.

Change-Id: Ida58ad8eb3ed3e76be87f511215cd3d2156b04f1
Signed-off-by: Elly Jones <ellyjones@chromium.org>;
Signed-off-by: Jason Glasgow <jglasgow@chromium.org>;

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=acbff33

[jglasgow, 2011-03-08 21:58:44]

I'd like a little more analysis on why the 3K probe is different from the 2K
probe function, especially since the 3K probe looks very much like the old 2K
probe code in the Code Aurora driver.  Why did upstream refactor?  Should 3K be
similarly refactored?

http://codereview.chromium.org/6652004/diff/1/drivers/usb/serial/qcserial.c
File drivers/usb/serial/qcserial.c (right):

http://codereview.chromium.org/6652004/diff/1/drivers/usb/serial/qcserial.c#n...
drivers/usb/serial/qcserial.c:102: /* TODO(ellyjones): Novatel Gobi 3000 QDL? */
Is that kernel or Google style?  Is there anyway to figure that out before
submitting?

[Elly Fong-Jones, 2011-03-08 22:31:19]

On 2011/03/08 21:58:44, jglasgow wrote:
> I'd like a little more analysis on why the 3K probe is different from the 2K
> probe function, especially since the 3K probe looks very much like the old 2K
> probe code in the Code Aurora driver.  Why did upstream refactor?  Should 3K
be
> similarly refactored?

No idea; mailed gregkh.

> http://codereview.chromium.org/6652004/diff/1/drivers/usb/serial/qcserial.c
> File drivers/usb/serial/qcserial.c (right):
> 
>
http://codereview.chromium.org/6652004/diff/1/drivers/usb/serial/qcserial.c#n...
> drivers/usb/serial/qcserial.c:102: /* TODO(ellyjones): Novatel Gobi 3000 QDL?
*/
> Is that kernel or Google style?  Is there anyway to figure that out before
> submitting?

Yes, but it requires me to hack a bit more on gobi3k-lib. Doing so now.

[Jason Glasgow, 2011-03-10 21:11:36]

LGTM

http://codereview.chromium.org/6652004/diff/5001/drivers/usb/serial/qcserial.c
File drivers/usb/serial/qcserial.c (right):

http://codereview.chromium.org/6652004/diff/5001/drivers/usb/serial/qcserial....
drivers/usb/serial/qcserial.c:168: } else {
I assume this change is because Gobi 3k has more than 4 ports?

[Elly Fong-Jones, 2011-03-10 21:15:56]

On 2011/03/10 21:11:36, Jason Glasgow wrote:
> LGTM
> 
> http://codereview.chromium.org/6652004/diff/5001/drivers/usb/serial/qcserial.c
> File drivers/usb/serial/qcserial.c (right):
> 
>
http://codereview.chromium.org/6652004/diff/5001/drivers/usb/serial/qcserial....
> drivers/usb/serial/qcserial.c:168: } else {
> I assume this change is because Gobi 3k has more than 4 ports?

Yep.