Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 6651022: Add --kloadaddr option to utilities (Closed)

Created:
9 years, 9 months ago by Che-Liang Chiou
Modified:
9 years ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add --kloadaddr option to utilities Kernel body load address was hard-coded to CROS_32BIT_ENTRY_ADDR, which could be an invalid/unavailable memory location on other platforms. This CL adds an option for setting the load address, and it is default to CROS_32BIT_ENTRY_ADDR to maintain backward-compatibility. BUG=chromium-os:1304 TEST=emerge vboot_reference successfully Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1a0975f

Patch Set 1 : Remove tabs #

Total comments: 8

Patch Set 2 : Code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -25 lines) Patch
M utility/dump_kernel_config.c View 1 6 chunks +53 lines, -7 lines 0 comments Download
M utility/vbutil_kernel.c View 1 18 chunks +41 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Che-Liang Chiou
9 years, 9 months ago (2011-03-09 13:37:13 UTC) #1
Randall Spangler
http://codereview.chromium.org/6651022/diff/3001/utility/dump_kernel_config.c File utility/dump_kernel_config.c (right): http://codereview.chromium.org/6651022/diff/3001/utility/dump_kernel_config.c#newcode25 utility/dump_kernel_config.c:25: { "kernelbodyloadaddress", 1, 0, OPT_KERNELBODYLOADADDRESS }, When you say ...
9 years, 9 months ago (2011-03-09 17:25:38 UTC) #2
Che-Liang Chiou
Thanks for comments. PTAL. http://codereview.chromium.org/6651022/diff/3001/utility/dump_kernel_config.c File utility/dump_kernel_config.c (right): http://codereview.chromium.org/6651022/diff/3001/utility/dump_kernel_config.c#newcode25 utility/dump_kernel_config.c:25: { "kernelbodyloadaddress", 1, 0, OPT_KERNELBODYLOADADDRESS ...
9 years, 9 months ago (2011-03-10 07:41:28 UTC) #3
Randall Spangler
9 years, 9 months ago (2011-03-10 16:39:40 UTC) #4
LGTM, thanks

Powered by Google App Engine
This is Rietveld 408576698