Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: chrome/browser/fav_icon_helper.h

Issue 6651014: Applied the IconType. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Addressed the comments Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/fav_icon_helper.h
diff --git a/chrome/browser/fav_icon_helper.h b/chrome/browser/fav_icon_helper.h
index 60fad35882001878e869b06a1676d00d580d72d8..2b52959cb28ec96f4003115935c63d2ac23bc867 100644
--- a/chrome/browser/fav_icon_helper.h
+++ b/chrome/browser/fav_icon_helper.h
@@ -121,10 +121,7 @@ class FavIconHelper : public TabContentsObserver {
// See description above class for details.
void OnFavIconDataForInitialURL(FaviconService::Handle handle,
- bool know_favicon,
- scoped_refptr<RefCountedMemory> data,
- bool expired,
- GURL icon_url);
+ history::FaviconData favicon);
// If the favicon has expired, asks the renderer to download the favicon.
// Otherwise asks history to update the mapping between page url and icon
@@ -133,10 +130,7 @@ class FavIconHelper : public TabContentsObserver {
// See description above class for details.
void OnFavIconData(FaviconService::Handle handle,
- bool know_favicon,
- scoped_refptr<RefCountedMemory> data,
- bool expired,
- GURL icon_url);
+ history::FaviconData favicon);
// Schedules a download for the specified entry. This adds the request to
// download_requests_.

Powered by Google App Engine
This is Rietveld 408576698