Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Unified Diff: chrome/browser/favicon_service.cc

Issue 6651014: Applied the IconType. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: sync Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon_service.cc
diff --git a/chrome/browser/favicon_service.cc b/chrome/browser/favicon_service.cc
index 58e92caba3fc23a7a99028b110731e198c04af7c..ddf632be069026792f81cf63152ffb2aaac0b689 100644
--- a/chrome/browser/favicon_service.cc
+++ b/chrome/browser/favicon_service.cc
@@ -15,13 +15,14 @@ FaviconService::FaviconService(Profile* profile) : profile_(profile) {
FaviconService::Handle FaviconService::GetFavicon(
const GURL& icon_url,
+ history::IconType icon_type,
CancelableRequestConsumerBase* consumer,
FaviconDataCallback* callback) {
GetFaviconRequest* request = new GetFaviconRequest(callback);
AddRequest(request, consumer);
HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
if (hs)
- hs->GetFavicon(request, icon_url);
+ hs->GetFavicon(request, icon_url, icon_type);
else
ForwardEmptyResultAsync(request);
return request->handle();
@@ -30,13 +31,14 @@ FaviconService::Handle FaviconService::GetFavicon(
FaviconService::Handle FaviconService::UpdateFaviconMappingAndFetch(
const GURL& page_url,
const GURL& icon_url,
+ history::IconType icon_type,
CancelableRequestConsumerBase* consumer,
FaviconService::FaviconDataCallback* callback) {
GetFaviconRequest* request = new GetFaviconRequest(callback);
AddRequest(request, consumer);
HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
if (hs)
- hs->UpdateFaviconMappingAndFetch(request, page_url, icon_url);
+ hs->UpdateFaviconMappingAndFetch(request, page_url, icon_url, icon_type);
else
ForwardEmptyResultAsync(request);
return request->handle();
@@ -44,6 +46,7 @@ FaviconService::Handle FaviconService::UpdateFaviconMappingAndFetch(
FaviconService::Handle FaviconService::GetFaviconForURL(
const GURL& page_url,
+ int icon_types,
CancelableRequestConsumerBase* consumer,
FaviconDataCallback* callback) {
GetFaviconRequest* request = new GetFaviconRequest(callback);
@@ -55,7 +58,7 @@ FaviconService::Handle FaviconService::GetFaviconForURL(
} else {
HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
if (hs)
- hs->GetFaviconForURL(request, page_url);
+ hs->GetFaviconForURL(request, page_url, icon_types);
else
ForwardEmptyResultAsync(request);
}
@@ -77,16 +80,17 @@ void FaviconService::SetImportedFavicons(
void FaviconService::SetFavicon(const GURL& page_url,
const GURL& icon_url,
- const std::vector<unsigned char>& image_data) {
+ const std::vector<unsigned char>& image_data,
+ history::IconType icon_type) {
HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
if (hs)
- hs->SetFavicon(page_url, icon_url, image_data);
+ hs->SetFavicon(page_url, icon_url, image_data, icon_type);
}
FaviconService::~FaviconService() {
}
void FaviconService::ForwardEmptyResultAsync(GetFaviconRequest* request) {
- request->ForwardResultAsync(FaviconDataCallback::TupleType(request->handle(),
- false, NULL, false, GURL()));
+ request->ForwardResultAsync(FaviconDataCallback::TupleType(
+ request->handle(), history::FaviconData()));
}

Powered by Google App Engine
This is Rietveld 408576698