Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer.cc

Issue 6651014: Applied the IconType. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: sync Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_html_writer.cc
diff --git a/chrome/browser/bookmarks/bookmark_html_writer.cc b/chrome/browser/bookmarks/bookmark_html_writer.cc
index 8b0e9790af88c57c32da174d326a05129c650d4d..ba70ed09c731e5bb38d39a5a37b864d7d096cade 100644
--- a/chrome/browser/bookmarks/bookmark_html_writer.cc
+++ b/chrome/browser/bookmarks/bookmark_html_writer.cc
@@ -439,7 +439,8 @@ bool BookmarkFaviconFetcher::FetchNextFavicon() {
if (favicons_map_->end() == iter) {
FaviconService* favicon_service =
profile_->GetFaviconService(Profile::EXPLICIT_ACCESS);
- favicon_service->GetFaviconForURL(GURL(url), &favicon_consumer_,
+ favicon_service->GetFaviconForURL(GURL(url), history::FAVICON,
+ &favicon_consumer_,
NewCallback(this, &BookmarkFaviconFetcher::OnFaviconDataAvailable));
return true;
} else {
@@ -451,17 +452,14 @@ bool BookmarkFaviconFetcher::FetchNextFavicon() {
void BookmarkFaviconFetcher::OnFaviconDataAvailable(
FaviconService::Handle handle,
- bool know_favicon,
- scoped_refptr<RefCountedMemory> data,
- bool expired,
- GURL icon_url) {
+ history::FaviconData favicon) {
GURL url;
if (!bookmark_urls_.empty()) {
url = GURL(bookmark_urls_.front());
bookmark_urls_.pop_front();
}
- if (know_favicon && data.get() && data->size() && !url.is_empty()) {
- favicons_map_->insert(make_pair(url.spec(), data));
+ if (favicon.is_valid() && !url.is_empty()) {
+ favicons_map_->insert(make_pair(url.spec(), favicon.image_data));
}
if (FetchNextFavicon()) {

Powered by Google App Engine
This is Rietveld 408576698