PRESUBMIT.py - Issue 6651009: add owners_unittest to PRESUBMIT.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PRESUBMIT.py

Issue 6651009: add owners_unittest to PRESUBMIT.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Top-level presubmit script for depot tools.	5 """Top-level presubmit script for depot tools.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API built into gcl.	8 details on the presubmit API built into gcl.

9 """	9 """

10	10

11 UNIT_TESTS = [	11 UNIT_TESTS = [

12 'tests.gcl_unittest',	12 'tests.gcl_unittest',

13 'tests.gclient_scm_test',	13 'tests.gclient_scm_test',

14 'tests.gclient_smoketest',	14 'tests.gclient_smoketest',

15 'tests.gclient_utils_test',	15 'tests.gclient_utils_test',

	16 'tests.owners_unittest',

16 'tests.presubmit_unittest',	17 'tests.presubmit_unittest',

17 'tests.scm_unittest',	18 'tests.scm_unittest',

18 'tests.trychange_unittest',	19 'tests.trychange_unittest',

19 'tests.watchlists_unittest',	20 'tests.watchlists_unittest',

20 ]	21 ]

21	22

22 def CommonChecks(input_api, output_api):	23 def CommonChecks(input_api, output_api):

23 output = []	24 output = []

24 # Verify that LocalPath() is local, e.g.:	25 # Verify that LocalPath() is local, e.g.:

25 # os.path.join(PresubmitLocalPath(), LocalPath()) == AbsoluteLocalPath()	26 # os.path.join(PresubmitLocalPath(), LocalPath()) == AbsoluteLocalPath()

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64	65

65	66

66 def WasGitClUploadHookModified(input_api, output_api):	67 def WasGitClUploadHookModified(input_api, output_api):

67 for affected_file in input_api.AffectedSourceFiles(None):	68 for affected_file in input_api.AffectedSourceFiles(None):

68 if (input_api.os_path.basename(affected_file.LocalPath()) ==	69 if (input_api.os_path.basename(affected_file.LocalPath()) ==

69 'git-cl-upload-hook'):	70 'git-cl-upload-hook'):

70 return [output_api.PresubmitPromptWarning(	71 return [output_api.PresubmitPromptWarning(

71 'Don\'t forget to fix git-cl to download the newest version of '	72 'Don\'t forget to fix git-cl to download the newest version of '

72 'git-cl-upload-hook')]	73 'git-cl-upload-hook')]

73 return []	74 return []

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »