Pepper/Flapper: Implement proxy for clipboard stuff.

Pepper/Flapper: Implement proxy for clipboard stuff.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77491

[brettw, 2011-03-09 17:13:18]

http://codereview.chromium.org/6650029/diff/1/ppapi/proxy/ppapi_messages_inte...
File ppapi/proxy/ppapi_messages_internal.h (right):

http://codereview.chromium.org/6650029/diff/1/ppapi/proxy/ppapi_messages_inte...
ppapi/proxy/ppapi_messages_internal.h:364:
IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBFlashClipboard_WritePlainText,
Does this really need to be a sync message? It seems like the errors that the
webkit implementation make are mostly misuse type things, and that the benefit
of actually returning the error aren't that big compared the the suckiness of a
sync message.

[viettrungluu, 2011-03-09 17:35:56]

http://codereview.chromium.org/6650029/diff/1/ppapi/proxy/ppapi_messages_inte...
File ppapi/proxy/ppapi_messages_internal.h (right):

http://codereview.chromium.org/6650029/diff/1/ppapi/proxy/ppapi_messages_inte...
ppapi/proxy/ppapi_messages_internal.h:364:
IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBFlashClipboard_WritePlainText,
On 2011/03/09 17:13:18, brettw wrote:
> Does this really need to be a sync message? It seems like the errors that the
> webkit implementation make are mostly misuse type things, and that the benefit
> of actually returning the error aren't that big compared the the suckiness of
a
> sync message.

Hmmm, could there be any issues if the plugin subsequently changes the var? (I
can never remember what order guarantees there are for IPC....)

[brettw, 2011-03-09 17:39:37]

http://codereview.chromium.org/6650029/diff/1/ppapi/proxy/ppapi_messages_inte...
File ppapi/proxy/ppapi_messages_internal.h (right):

http://codereview.chromium.org/6650029/diff/1/ppapi/proxy/ppapi_messages_inte...
ppapi/proxy/ppapi_messages_internal.h:364:
IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBFlashClipboard_WritePlainText,
Over the IPC the contents of the var are passed by value so we don't have to
worry about this kind of thing.

[viettrungluu, 2011-03-09 18:09:39]

http://codereview.chromium.org/6650029/diff/1/ppapi/proxy/ppapi_messages_inte...
File ppapi/proxy/ppapi_messages_internal.h (right):

http://codereview.chromium.org/6650029/diff/1/ppapi/proxy/ppapi_messages_inte...
ppapi/proxy/ppapi_messages_internal.h:364:
IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBFlashClipboard_WritePlainText,
On 2011/03/09 17:39:37, brettw wrote:
> Over the IPC the contents of the var are passed by value so we don't have to
> worry about this kind of thing.

Done then. I think.

[brettw, 2011-03-09 18:11:47]

LGTM