Don't ignore first argument in TryChange.

Don't ignore first argument in TryChange.

BUG=none
TEST=`git try foo` gives a proper error message.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77470

[Bernhard Bauer, 2011-03-09 15:22:41]

please review.

[M-A Ruel, 2011-03-09 15:30:34]

http://codereview.chromium.org/6650025/diff/1/trychange.py
File trychange.py (right):

http://codereview.chromium.org/6650025/diff/1/trychange.py#newcode373
trychange.py:373: print options.diff
It's assumed that --dry-run is used with --verbose. If you want to print it, do
it only with:
if not logging.getLogger().isEnabledFor(logging.INFO):
  print options.diff

otherwise it would be printed two times in a row.

http://codereview.chromium.org/6650025/diff/1/trychange.py#newcode622
trychange.py:622: if len(args) > 0:
Ugh, this code is ugly. Since you're touching it anyway, replace lines 622-629
with:
if args:
  parser.error('Extra argument(s) "%s" not understood' % ' '.join(args))

[Bernhard Bauer, 2011-03-09 15:55:11]

http://codereview.chromium.org/6650025/diff/1/trychange.py
File trychange.py (right):

http://codereview.chromium.org/6650025/diff/1/trychange.py#newcode373
trychange.py:373: print options.diff
On 2011/03/09 15:30:34, Marc-Antoine Ruel wrote:
> It's assumed that --dry-run is used with --verbose. If you want to print it,
do
> it only with:
> if not logging.getLogger().isEnabledFor(logging.INFO):
>   print options.diff
> 
> otherwise it would be printed two times in a row.

I see. I wanted to make it analog to _SendChangeHTTP, but there the log
statement comes after the dry_run check.

I guess we should make --dry_run fully imply --verbose then?

http://codereview.chromium.org/6650025/diff/1/trychange.py#newcode622
trychange.py:622: if len(args) > 0:
On 2011/03/09 15:30:34, Marc-Antoine Ruel wrote:
> Ugh, this code is ugly. Since you're touching it anyway, replace lines 622-629
> with:
> if args:
>   parser.error('Extra argument(s) "%s" not understood' % ' '.join(args))
> 

Done.

[M-A Ruel, 2011-03-09 16:06:58]

lgtm

[commit-bot: I haz the power, 2011-03-09 16:11:08]

Change committed as 77470

[Bernhard Bauer, 2011-03-09 16:30:43]

On 2011/03/09 16:11:08, commit-bot wrote:
> Change committed as 77470

Whoops, looks like that didn't work :-/ 

Do you know why commit-bot didn't find the syntax error?

[M-A Ruel, 2011-03-09 16:34:04]

On 2011/03/09 16:30:43, Bernhard Bauer wrote:
> On 2011/03/09 16:11:08, commit-bot wrote:
> > Change committed as 77470
> 
> Whoops, looks like that didn't work :-/ 
> 
> Do you know why commit-bot didn't find the syntax error?

Looks like presubmit check isn't run at all :( looking.