Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Issue 6650021: Refactor construction of switch statements to avoid subgraphs. (Closed)

Created:
9 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor construction of switch statements to avoid subgraphs. Refactor construction of switch statements so it doesn't use class HSubgraph. There are also a few improvements. We do not use an auxiliary list of comparisons because they're embedded as a linked list in the graph under construction. We share a common break block for all breaks from the same switch. We do not insert empty blocks unless necessary to maintain edge-split form. There is also a bug fix. The entry to a clause body is a potential join and must have a join ID set, otherwise deoptimization within the body can go to an unpredictable place in the unoptimized code. Committed: http://code.google.com/p/v8/source/detail?r=7099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -156 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.h View 3 chunks +5 lines, -0 lines 0 comments Download
M src/ast.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/hydrogen.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +95 lines, -150 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 9 months ago (2011-03-09 08:41:26 UTC) #1
fschneider
9 years, 9 months ago (2011-03-09 12:04:15 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698