Autofill extend profiles to include multi-valued fields, part 2.

chrome/browser/autofill/autofill_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "base/scoped_vector.h"
 #include "base/string16.h"
@@ skipping 654 matching lines @@
 
 // Test that we cull duplicate profile suggestions.
 TEST_F(AutofillManagerTest, GetProfileSuggestionsWithDuplicates) {
   // Set up our form data.
   FormData form;
   CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Add a duplicate profile.
-  AutoFillProfile* duplicate_profile = static_cast<AutoFillProfile*>(
-      autofill_manager_->GetProfileWithGUID(
-          "00000000-0000-0000-0000-000000000001")->Clone());
+  AutoFillProfile* duplicate_profile =
+      new AutoFillProfile(
+          *(autofill_manager_->GetProfileWithGUID(
+              "00000000-0000-0000-0000-000000000001")));

[Ilya Sherman, 2011/03/09 00:50:50]

Won't this leak memory?  Or did we have a double-free before?

[dhollowa, 2011/03/09 01:55:47]

No, this AddProfile call takes ownership.  It adds it to a scoped vector in the
PDM.
On 2011/03/09 00:50:50, Ilya Sherman wrote:

   autofill_manager_->AddProfile(duplicate_profile);
 
   const FormField& field = form.fields[0];
   GetAutoFillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<string16>());
 
   // Test that we sent the right message to the renderer.
@@ skipping 1058 matching lines @@
 #else
   ASSERT_FALSE(profile()->GetPrefs()->GetBoolean(
       prefs::kAutoFillAuxiliaryProfilesEnabled));
   profile()->GetPrefs()->SetBoolean(
       prefs::kAutoFillAuxiliaryProfilesEnabled, true);
   profile()->GetPrefs()->ClearPref(prefs::kAutoFillAuxiliaryProfilesEnabled);
   ASSERT_FALSE(profile()->GetPrefs()->GetBoolean(
       prefs::kAutoFillAuxiliaryProfilesEnabled));
 #endif
 }