Issue 6649008: Fix SAFT operation on Alex.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6649008: Fix SAFT operation on Alex. (Closed)

Created:
9 years, 9 months ago by vb

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, truty

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/saft.git@master

Visibility:
Public.

Description

A few recent changes broke SAFT operation. - the BIOS image now contains different firmware flavors - the mosys utility now deploys locking and can fail to run if other programs are running. To address the issue SAFT determines if firmware sections are not the same and copies firmware B into firmware A. A `-f' flag is being added to mosys command line to avoid locking attempts (it operates on a separate file anyways). Change-Id: I37d14696a7370bdc23abd1add67814ce8fe156dd BUG=chrome-os-partner:2617 TEST=see below . build the test image . install it on DUT . copy a new firmware image into /var . run the test localhost saft # /usr/sbin/firmware/saft/runtests.sh /var/<new firmware> . follow the prompts (unplugging/plugging back the USB stick) . After the test ends observe test results: localhost saft # grep 'modify firmware A' /var/fw_test_log.txt 02:36:23 PM: modify firmware A to match B localhost saft # tail -1 /var/fw_test_log.txt 03:00:09 PM: we are done! localhost saft # Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=eb153c0

Patch Set 1 : Fix SAFT operation. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -2 lines)			Patch
M	chromeos_interface.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	flashrom_handler.py	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	saft_flashrom_util.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	saft_utility.py	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

Does SAFT restore the original firmware state at the end? If so, LGTM.

9 years, 9 months ago (2011-03-09 20:45:29 UTC) #2

9 years, 9 months ago (2011-03-09 20:56:59 UTC) #3

On Wed, Mar 9, 2011 at 12:45 PM,  <rspangler@chromium.org> wrote:
> Does SAFT restore the original firmware state at the end?  If so, LGTM.
>

yes, this is the second last step SAFT takes, see line 681 in
saft_utility.py
(http://gitrw.chromium.org/gitweb/?p=saft.git;a=blob;f=saft_utility.py;h=61bac...):


('1:1:1:0:3', FST.revert_firmware),

cheers,
/v


>
> http://codereview.chromium.org/6649008/
>

Expand Messages | Collapse Messages