Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3922)

Unified Diff: chrome/browser/chromeos/cros/update_library.cc

Issue 6648009: Modify UpdateLibrary to use async RequestUpdateCheck call (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/cros/update_library.h ('k') | chrome/browser/chromeos/login/update_screen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/update_library.cc
diff --git a/chrome/browser/chromeos/cros/update_library.cc b/chrome/browser/chromeos/cros/update_library.cc
index 80a4b96734452686530e2768afe4d5be47c5f006..44c7d763347986f172e006495fed9b0796c55caa 100644
--- a/chrome/browser/chromeos/cros/update_library.cc
+++ b/chrome/browser/chromeos/cros/update_library.cc
@@ -36,11 +36,9 @@ class UpdateLibraryImpl : public UpdateLibrary {
observers_.RemoveObserver(observer);
}
- bool CheckForUpdate() {
- if (!CrosLibrary::Get()->EnsureLoaded())
- return false;
-
- return InitiateUpdateCheck();
+ void RequestUpdateCheck(chromeos::UpdateCallback callback, void* user_data) {
+ if (CrosLibrary::Get()->EnsureLoaded())
+ chromeos::RequestUpdateCheck(callback, user_data);
}
bool RebootAfterUpdate() {
@@ -119,7 +117,10 @@ class UpdateLibraryStubImpl : public UpdateLibrary {
~UpdateLibraryStubImpl() {}
void AddObserver(Observer* observer) {}
void RemoveObserver(Observer* observer) {}
- bool CheckForUpdate() { return false; }
+ void RequestUpdateCheck(chromeos::UpdateCallback callback, void* user_data) {
+ if (callback)
+ callback(user_data, UPDATE_RESULT_FAILED, "stub update");
+ }
bool RebootAfterUpdate() { return false; }
bool SetReleaseTrack(const std::string& track) { return false; }
std::string GetReleaseTrack() { return "beta-channel"; }
« no previous file with comments | « chrome/browser/chromeos/cros/update_library.h ('k') | chrome/browser/chromeos/login/update_screen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698