Modify UpdateLibrary to use async RequestUpdateCheck call

chrome/browser/ui/webui/options/about_page_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/about_page_handler.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
@@ skipping 297 matching lines @@
 #endif
 }
 
 #if defined(OS_CHROMEOS)
 
 void AboutPageHandler::CheckNow(const ListValue* args) {
   // Make sure that libcros is loaded and OOBE is complete.
   if (chromeos::CrosLibrary::Get()->EnsureLoaded() &&
       (!WizardController::default_controller() ||
         WizardController::IsDeviceRegistered())) {
-    chromeos::CrosLibrary::Get()->GetUpdateLibrary()->CheckForUpdate();
+    chromeos::CrosLibrary::Get()->GetUpdateLibrary()->
+        RequestUpdateCheck(NULL /*no callback*/, NULL /*no userdata*/);

[altimofeev, 2011/03/10 08:27:34]

nit: AFAIK, there is no such comment style. But you can move comments to one
line before the method call:
// Request update check without callback and user data.
chromeos::CrosLibrary::Get()->GetUpdateLibrary()->
    RequestUpdateCheck(NULL, NULL);

[Nikita (slow), 2011/03/10 11:32:04]

Should place each NULL parameter on a separate line and use // style comment
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Implementation...

[stevenjb, 2011/03/10 17:28:50]

Done.

   }
 }
 
 void AboutPageHandler::RestartNow(const ListValue* args) {
   chromeos::CrosLibrary::Get()->GetPowerLibrary()->RequestRestart();
 }
 
 void AboutPageHandler::UpdateStatus(
     const chromeos::UpdateLibrary::Status& status) {
   string16 message;
@@ skipping 80 matching lines @@
 
 void AboutPageHandler::OnOSVersion(chromeos::VersionLoader::Handle handle,
                                    std::string version) {
   if (version.size()) {
     scoped_ptr<Value> version_string(Value::CreateStringValue(version));
     web_ui_->CallJavascriptFunction("AboutPage.updateOSVersionCallback",
                                     *version_string);
   }
 }
 #endif