Libcros changes for issue_12743: Add async RequestUpdateCheck call.

Libcros changes for issue_12743: Add async RequestUpdateCheck call.

BUG=chromium-os:12743
TEST=Load settings and About; both should load in a reasonable amount of time. Verify that About / update works properly.

See: http://codereview.chromium.org/6648009/ for Chrome changes

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bb81ec1

[stevenjb, 2011-03-08 22:30:13]

Please take a look, P0 issue for R11, thanks.

[petkov, 2011-03-08 22:49:18]

LGTM w/ a suggestion.

http://codereview.chromium.org/6648007/diff/1004/chromeos_update_engine.cc
File chromeos_update_engine.cc (right):

http://codereview.chromium.org/6648007/diff/1004/chromeos_update_engine.cc#ne...
chromeos_update_engine.cc:231: dbus::Proxy* proxy;
any reason why this is not a scoped_ptr? then you don't need the destructor.

[stevenjb, 2011-03-09 00:17:16]

Good suggestion. I dropped into "C" mode when writing the struct code :)

I also modified chromeos_network.cc where I pulled this code from to remain
consistent.

[petkov, 2011-03-09 00:32:09]

still LGTM

http://codereview.chromium.org/6648007/diff/2005/chromeos_network.cc
File chromeos_network.cc (right):

http://codereview.chromium.org/6648007/diff/2005/chromeos_network.cc#newcode1255
chromeos_network.cc:1255: const char* service_path) :
style says the colon should be on the next line, i think

http://codereview.chromium.org/6648007/diff/2005/chromeos_update_engine.cc
File chromeos_update_engine.cc (right):

http://codereview.chromium.org/6648007/diff/2005/chromeos_update_engine.cc#ne...
chromeos_update_engine.cc:228: scoped_ptr<dbus::Proxy> proxy;
actually, does this need to be a pointer at all?