Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 6647024: Add bailout to x64 pixel array lithium instructions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix 80col Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1772 matching lines...) Expand 10 before | Expand all | Expand 10 after
1783 ASSERT(instr->key()->representation().IsInteger32()); 1783 ASSERT(instr->key()->representation().IsInteger32());
1784 LOperand* obj = UseRegisterAtStart(instr->object()); 1784 LOperand* obj = UseRegisterAtStart(instr->object());
1785 LOperand* key = UseRegisterAtStart(instr->key()); 1785 LOperand* key = UseRegisterAtStart(instr->key());
1786 LLoadKeyedFastElement* result = new LLoadKeyedFastElement(obj, key); 1786 LLoadKeyedFastElement* result = new LLoadKeyedFastElement(obj, key);
1787 return AssignEnvironment(DefineSameAsFirst(result)); 1787 return AssignEnvironment(DefineSameAsFirst(result));
1788 } 1788 }
1789 1789
1790 1790
1791 LInstruction* LChunkBuilder::DoLoadPixelArrayElement( 1791 LInstruction* LChunkBuilder::DoLoadPixelArrayElement(
1792 HLoadPixelArrayElement* instr) { 1792 HLoadPixelArrayElement* instr) {
1793 Abort("Pixel array loads in generated code cause segfaults (danno)");
1793 ASSERT(instr->representation().IsInteger32()); 1794 ASSERT(instr->representation().IsInteger32());
1794 ASSERT(instr->key()->representation().IsInteger32()); 1795 ASSERT(instr->key()->representation().IsInteger32());
1795 LOperand* external_pointer = 1796 LOperand* external_pointer =
1796 UseRegisterAtStart(instr->external_pointer()); 1797 UseRegisterAtStart(instr->external_pointer());
1797 LOperand* key = UseRegisterAtStart(instr->key()); 1798 LOperand* key = UseRegisterAtStart(instr->key());
1798 LLoadPixelArrayElement* result = 1799 LLoadPixelArrayElement* result =
1799 new LLoadPixelArrayElement(external_pointer, key); 1800 new LLoadPixelArrayElement(external_pointer, key);
1800 return DefineSameAsFirst(result); 1801 return DefineSameAsFirst(result);
1801 } 1802 }
1802 1803
(...skipping 21 matching lines...) Expand all
1824 LOperand* key = needs_write_barrier 1825 LOperand* key = needs_write_barrier
1825 ? UseTempRegister(instr->key()) 1826 ? UseTempRegister(instr->key())
1826 : UseRegisterOrConstantAtStart(instr->key()); 1827 : UseRegisterOrConstantAtStart(instr->key());
1827 1828
1828 return AssignEnvironment(new LStoreKeyedFastElement(obj, key, val)); 1829 return AssignEnvironment(new LStoreKeyedFastElement(obj, key, val));
1829 } 1830 }
1830 1831
1831 1832
1832 LInstruction* LChunkBuilder::DoStorePixelArrayElement( 1833 LInstruction* LChunkBuilder::DoStorePixelArrayElement(
1833 HStorePixelArrayElement* instr) { 1834 HStorePixelArrayElement* instr) {
1835 Abort("Pixel array stores in generated code sometimes segfaults (danno)");
1834 ASSERT(instr->value()->representation().IsInteger32()); 1836 ASSERT(instr->value()->representation().IsInteger32());
1835 ASSERT(instr->external_pointer()->representation().IsExternal()); 1837 ASSERT(instr->external_pointer()->representation().IsExternal());
1836 ASSERT(instr->key()->representation().IsInteger32()); 1838 ASSERT(instr->key()->representation().IsInteger32());
1837 1839
1838 LOperand* external_pointer = UseRegister(instr->external_pointer()); 1840 LOperand* external_pointer = UseRegister(instr->external_pointer());
1839 LOperand* val = UseTempRegister(instr->value()); 1841 LOperand* val = UseTempRegister(instr->value());
1840 LOperand* key = UseRegister(instr->key()); 1842 LOperand* key = UseRegister(instr->key());
1841 1843
1842 return new LStorePixelArrayElement(external_pointer, key, val); 1844 return new LStorePixelArrayElement(external_pointer, key, val);
1843 } 1845 }
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
2038 2040
2039 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 2041 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
2040 HEnvironment* outer = current_block_->last_environment()->outer(); 2042 HEnvironment* outer = current_block_->last_environment()->outer();
2041 current_block_->UpdateEnvironment(outer); 2043 current_block_->UpdateEnvironment(outer);
2042 return NULL; 2044 return NULL;
2043 } 2045 }
2044 2046
2045 } } // namespace v8::internal 2047 } } // namespace v8::internal
2046 2048
2047 #endif // V8_TARGET_ARCH_X64 2049 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698