Issue 6647015: X64: Change kSmiConstantRegister to r12.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6647015: X64: Change kSmiConstantRegister to r12. (Closed)

Created:
9 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

X64: Change kSmiConstantRegister to r12. We never use the smi register in places where it matters that r12 as a base register needs an extra SIB byte. Might as well free up the unencumbered r15 register instead. Committed: http://code.google.com/p/v8/source/detail?r=7113

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -62 lines)			Patch
M	src/x64/assembler-x64.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	9 chunks	+14 lines, -14 lines	0 comments	Download
M	src/x64/register-allocator-x64-inl.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-assembler-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-macro-assembler-x64.cc	View	9 chunks	+28 lines, -28 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

9 years, 9 months ago (2011-03-09 14:05:18 UTC) #2

LGTM.  I assume you checked that r15 is callee saved on both linux 64 and Win64?

Expand Messages | Collapse Messages