GTK: Set WM_CLASS to webapp names on webapp windows.

GTK: Set WM_CLASS to webapp names on webapp windows.

BUG=20587
TEST=1) Open chrome --app=<somesite> 2) run xprop and click the window. WM_CLASS should be set to the webapp name instead of "Google Chrome"

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77495

[Elliot Glaysher, 2011-03-09 02:13:51]

Grepping the docky source code showed they only have WM_CLASS as a string
constant in one place. They'll need to implement WM_CLASS reading before this
works for them.

Otherwise, the xfwm app switcher realizes it's a different program.

[Evan Martin, 2011-03-09 03:10:28]

How does prism do it?

brevity due to phone
On Mar 8, 2011 6:13 PM, <erg@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Message:
> Grepping the docky source code showed they only have WM_CLASS as a string
> constant in one place. They'll need to implement WM_CLASS reading before
> this
> works for them.
>
> Otherwise, the xfwm app switcher realizes it's a different program.
>
> Description:
> GTK: Set WM_CLASS to webapp names on webapp windows.
>
> BUG=20587
> TEST=1) Open chrome --app=<somesite> 2) run xprop and click the window.
> WM_CLASS
> should be set to the webapp name instead of "Google Chrome"
>
> Please review this at http://codereview.chromium.org/6647008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M chrome/browser/ui/browser.h
> M chrome/browser/ui/gtk/browser_window_gtk.cc
>
>
> Index: chrome/browser/ui/browser.h
> diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
> index
>
5bb8a98b93861266c29520bacc71cbfe02ae2818..98e2622357a2017d61aa9f957f93c4abb4b65561

> 100644
> --- a/chrome/browser/ui/browser.h
> +++ b/chrome/browser/ui/browser.h
> @@ -176,6 +176,7 @@ class Browser : public TabHandlerDelegate,
> // Accessors
> ////////////////////////////////////////////////////////////////
>
> Type type() const { return type_; }
> + const std::string& app_name() const { return app_name_; }
> Profile* profile() const { return profile_; }
> const std::vector<std::wstring>& user_data_dir_profiles() const;
>
> Index: chrome/browser/ui/gtk/browser_window_gtk.cc
> diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc
> b/chrome/browser/ui/gtk/browser_window_gtk.cc
> index
>
e1b598698b978ec68b263165bf91c941e7f436f2..2f4b7a9669c98e08c2bdaf96205af51b7bf3e471

> 100644
> --- a/chrome/browser/ui/gtk/browser_window_gtk.cc
> +++ b/chrome/browser/ui/gtk/browser_window_gtk.cc
> @@ -10,6 +10,7 @@
>
> #include "base/base_paths.h"
> #include "base/command_line.h"
> +#include "base/i18n/file_util_icu.h"
> #include "base/logging.h"
> #include "base/message_loop.h"
> #include "base/path_service.h"
> @@ -285,6 +286,16 @@ BrowserWindowGtk::BrowserWindowGtk(Browser* browser)
> gtk_window_group_add_window(gtk_window_group_new(), window_);
> g_object_unref(gtk_window_get_group(window_));
>
> + if (browser_->type() & Browser::TYPE_APP) {
> + std::string wmclassname = browser_->app_name();
> + if (wmclassname != DevToolsWindow::kDevToolsApp) {
> + file_util::ReplaceIllegalCharactersInPath(&wmclassname, '_');
> + TrimString(wmclassname, "_", &wmclassname);
> + gtk_window_set_wmclass(window_, wmclassname.c_str(),
> + wmclassname.c_str());
> + }
> + }
> +
> // For popups, we initialize widgets then set the window geometry,
> because
> // popups need the widgets inited before they can set the window size
> // properly. For other windows, we set the geometry first to prevent
> resize
>
>

[Elliot Glaysher, 2011-03-09 17:50:23]

On 2011/03/09 03:10:28, Evan Martin wrote:
> How does prism do it?

As far as I can tell, it doesn't. All the prism windows have the same WM_CLASS
and docky doesn't recognize that they're different.

[Evan Martin, 2011-03-09 17:57:06]

Do you know whether it works in Unity?

http://codereview.chromium.org/6647008/diff/1/chrome/browser/ui/browser.h
File chrome/browser/ui/browser.h (right):

http://codereview.chromium.org/6647008/diff/1/chrome/browser/ui/browser.h#new...
chrome/browser/ui/browser.h:179: const std::string& app_name() const { return
app_name_; }
Hm, I wonder what encoding this is in.

[Elliot Glaysher, 2011-03-09 19:06:16]

On 2011/03/09 17:57:06, Evan Martin wrote:
> Do you know whether it works in Unity?

I don't know how to install that. There aren't lucid packages.

>
http://codereview.chromium.org/6647008/diff/1/chrome/browser/ui/browser.h#new...
> chrome/browser/ui/browser.h:179: const std::string& app_name() const { return
> app_name_; }
> Hm, I wonder what encoding this is in.

UTF-8; the code in web_app.cc just copies details out of a GURL instance.

[Evan Martin, 2011-03-09 19:07:19]

OK, LGTM.  perhaps ask on the bug for feedback about what to do about docky