chrome/browser/password_manager/password_store_win.h - Issue 6646051: Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_win.h

Issue 6646051: Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use non-zero tests until http://crbug.com/77650 is addressed. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_mac_unittest.cc ('k') | chrome/browser/password_manager/password_store_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_win.h

diff --git a/chrome/browser/password_manager/password_store_win.h b/chrome/browser/password_manager/password_store_win.h

index e58f71723b781cb7ffb9324320b5a7de8e051b48..cdde4a2b24a80217a28c296376e5b9b14355986b 100644

--- a/chrome/browser/password_manager/password_store_win.h

+++ b/chrome/browser/password_manager/password_store_win.h

@@ -1,4 +1,4 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

@@ -34,9 +34,7 @@ class PasswordStoreWin : public PasswordStoreDefault {

void OnWebDataServiceRequestDone(WebDataService::Handle h,

const WDTypedResult* result);

- virtual void NotifyConsumer(

- GetLoginsRequest* request,

- const std::vector<webkit_glue::PasswordForm*> forms);

+ virtual void ForwardLoginsResult(GetLoginsRequest* request);

// Takes ownership of |request| and tracks it under |handle|.

void TrackRequest(WebDataService::Handle handle, GetLoginsRequest* request);