chrome/browser/password_manager/password_store_default_unittest.cc - Issue 6646051: Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_default_unittest.cc

Issue 6646051: Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use non-zero tests until http://crbug.com/77650 is addressed. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_default.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_default_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_default_unittest.cc b/chrome/browser/password_manager/password_store_default_unittest.cc

index 97f67b386dba8cb19a363a90c215f8ef26f0e111..19b70a1b29ff2b2aa15601ae78e8682048ec0ca7 100644

--- a/chrome/browser/password_manager/password_store_default_unittest.cc

+++ b/chrome/browser/password_manager/password_store_default_unittest.cc

@@ -10,6 +10,7 @@

#include "base/utf_string_conversions.h"

#include "base/synchronization/waitable_event.h"

#include "chrome/browser/password_manager/password_store_change.h"

+#include "chrome/browser/password_manager/password_store_consumer.h"

#include "chrome/browser/password_manager/password_store_default.h"

#include "chrome/browser/password_manager/password_form_data.h"

#include "chrome/browser/prefs/pref_service.h"

@@ -38,7 +39,8 @@ namespace {

class MockPasswordStoreConsumer : public PasswordStoreConsumer {

public:

MOCK_METHOD2(OnPasswordStoreRequestDone,

- void(int, const std::vector<webkit_glue::PasswordForm*>&));

+ void(CancelableRequestProvider::Handle,

+ const std::vector<webkit_glue::PasswordForm*>&));

};

class MockWebDataServiceConsumer : public WebDataServiceConsumer {

« no previous file with comments | « chrome/browser/password_manager/password_store_default.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »