chrome/browser/automation/automation_provider_observers.cc - Issue 6646051: Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 6646051: Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use non-zero tests until http://crbug.com/77650 is addressed. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/automation_provider_observers.h ('k') | chrome/browser/automation/testing_automation_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/automation_provider_observers.cc

diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc

index b246e1cc305fda4e884583097a9383cac892c40b..94b80a3e2e1d12246ae36991db7cbf2259ad7212 100644

--- a/chrome/browser/automation/automation_provider_observers.cc

+++ b/chrome/browser/automation/automation_provider_observers.cc

@@ -1464,7 +1464,8 @@ AutomationProviderGetPasswordsObserver::

~AutomationProviderGetPasswordsObserver() {}

void AutomationProviderGetPasswordsObserver::OnPasswordStoreRequestDone(

- int handle, const std::vector<webkit_glue::PasswordForm*>& result) {

+ CancelableRequestProvider::Handle handle,

+ const std::vector<webkit_glue::PasswordForm*>& result) {

if (!provider_) {

delete this;

return;