chrome/browser/automation/automation_provider_observers.h - Issue 6646051: Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider_observers.h

Issue 6646051: Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Responding to review comments. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/scoped_vector_unittest.cc ('K') | « base/scoped_vector_unittest.cc ('k') | chrome/browser/automation/automation_provider_observers.cc » ('j') | chrome/browser/password_manager/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/automation_provider_observers.h

diff --git a/chrome/browser/automation/automation_provider_observers.h b/chrome/browser/automation/automation_provider_observers.h

index 2eff551ee352445e39f5b96023c8bd68d6d537fb..0b2e0acb41490419b598af5b345475673d76742d 100644

--- a/chrome/browser/automation/automation_provider_observers.h

+++ b/chrome/browser/automation/automation_provider_observers.h

@@ -867,8 +867,7 @@ class AutomationProviderImportSettingsObserver

};

// Allows automation provider to wait for getting passwords to finish.

-class AutomationProviderGetPasswordsObserver

- : public PasswordStoreConsumer {

+class AutomationProviderGetPasswordsObserver : public PasswordStoreConsumer {

public:

AutomationProviderGetPasswordsObserver(

AutomationProvider* provider,

@@ -876,7 +875,8 @@ class AutomationProviderGetPasswordsObserver

virtual ~AutomationProviderGetPasswordsObserver();

virtual void OnPasswordStoreRequestDone(

- int handle, const std::vector<webkit_glue::PasswordForm*>& result);

+ PasswordStore::Handle handle,

+ const std::vector<webkit_glue::PasswordForm*>& result);

private:

base::WeakPtr<AutomationProvider> provider_;