Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest

base/memory/scoped_vector.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MEMORY_SCOPED_VECTOR_H_
 #define BASE_MEMORY_SCOPED_VECTOR_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 44 matching lines @@
 
   void reset() { STLDeleteElements(&v); }
   void reserve(size_t capacity) { v.reserve(capacity); }
   void resize(size_t new_size) { v.resize(new_size); }
 
   // Lets the ScopedVector take ownership of |x|.
   iterator insert(iterator position, T* x) {
     return v.insert(position, x);
   }
 
+  // Lets the ScopedVector take ownership of elements in [first,last).
+  template<typename InputIterator>
+  void insert(iterator position, InputIterator first, InputIterator last) {
+    v.insert(position, first, last);
+  }
+
   iterator erase(iterator position) {
     delete *position;
     return v.erase(position);
   }
 
   iterator erase(iterator first, iterator last) {
     STLDeleteContainerPointers(first, last);
     return v.erase(first, last);
   }
 
   // Like |erase()|, but doesn't delete the element at |position|.
   iterator weak_erase(iterator position) {
     return v.erase(position);
   }
 
   // Like |erase()|, but doesn't delete the elements in [first, last).
   iterator weak_erase(iterator first, iterator last) {
     return v.erase(first, last);
   }
  private:
   std::vector<T*> v;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedVector);
 };
 
 #endif  // BASE_MEMORY_SCOPED_VECTOR_H_